Feedback-ID: i131946ab:Fastmail
Message-ID: <64b62678-ca3e-36f8-f0f2-bb430493ef4d@enterprisedb.com>
Date: Thu, 19 Jan 2023 15:27:20 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.1
Subject: Re: ANY_VALUE aggregate
Content-Language: en-US
To: Vik Fearing <vik@postgresfriends.org>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <5cff866c-10a8-d2df-32cb-e9072e6b04a2@postgresfriends.org>
 <bf4652c9-0283-af94-31c5-3ac936f07878@postgresfriends.org>
 <464ece4e-fabb-ddac-60da-897493c4476d@enterprisedb.com>
 <538ac95d-f12e-92b8-0e22-85b6e35fdec9@postgresfriends.org>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
In-Reply-To: <538ac95d-f12e-92b8-0e22-85b6e35fdec9@postgresfriends.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: <https://www.postgresql.org/message-id/64b62678-ca3e-36f8-f0f2-bb430493ef4d%40enterprisedb.com>
Precedence: bulk

On 18.01.23 18:01, Vik Fearing wrote:
> On 1/18/23 16:06, Peter Eisentraut wrote:
>> On 05.12.22 21:18, Vik Fearing wrote:
>>> On 12/5/22 15:57, Vik Fearing wrote:
>>>> The SQL:2023 Standard defines a new aggregate named ANY_VALUE.  It 
>>>> returns an implementation-dependent (i.e. non-deterministic) value 
>>>> from the rows in its group.
>>>>
>>>> PFA an implementation of this aggregate.
>>>
>>> Here is v2 of this patch.  I had forgotten to update sql_features.txt.
>>
>> In your patch, the documentation says the definition is 
>> any_value("any") but the catalog definitions are 
>> any_value(anyelement).  Please sort that out.
>>
>> Since the transition function is declared strict, null values don't 
>> need to be checked.
> 
> Thank you for the review.  Attached is a new version rebased to d540a02a72.

This looks good to me now.