From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: =?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>,
        Peter Smith <smithpb2250@gmail.com>,
        Michael Paquier <michael@paquier.xyz>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
In-reply-to: <0f5256ec-d63e-4e0f-9b71-750a7a4e5c01@dunslane.net>
References: <CAHut+PvfaUZQR3rEnj-Dcg_6713Wu4yRdd-yZkkC9NVsARht8A@mail.gmail.com> <556792.1733967676@sss.pgh.pa.us> <CAHut+Ps6Q+i_3xS6H7ybw3-hx9+2QOuneTJwHArxqxFnKX5+4g@mail.gmail.com> <564915.1733971586@sss.pgh.pa.us> <CAHut+PvFGytgJT+K_e2x+uWKuVYCBR3HNaNtPKYEkO3YxAwZvw@mail.gmail.com> <Z1peKSb8roiDNgRj@paquier.xyz> <CAHut+PvYsVhF5k-mYHVEFdpijdgkYRtoeWVxdspxio0ePRpkug@mail.gmail.com> <87pllx5cqn.fsf@wibble.ilmari.org> <87msh159c3.fsf@wibble.ilmari.org> <0f5256ec-d63e-4e0f-9b71-750a7a4e5c01@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Thu, 12 Dec 2024 10:28:38 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <651127.1734017715.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Thu, 12 Dec 2024 10:35:15 -0500
Message-ID: <651128.1734017715@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/651128.1734017715%40sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:
> On 2024-12-12 Th 8:17 AM, Dagfinn Ilmari Mannsåker wrote:
>> Here's a more thorough patch, that also applies the fat comma treatment
>> to other pg_createsubscriber invocations in the same file that don't
>> currently happen to be mangled by perltidy.  It also adds trailing
>> commas to the last item in multi-line command arrays, which is common
>> perl style.

> +1 for this approach.

Indeed, this is much nicer if it's something perltidy knows about.

However, I know we have the same issue in many other places.
Anyone feel like running through all the TAP scripts?

			regards, tom lane