Message-ID: <65326908-f1ef-40ce-acc6-414801c30946@gmail.com>
Date: Mon, 27 Nov 2023 09:45:33 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Synchronizing slots from primary to standby
Content-Language: en-US
To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>,
 Peter Smith <smithpb2250@gmail.com>, shveta malik <shveta.malik@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
 "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>,
 Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
 Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 Bruce Momjian <bruce@momjian.us>, Ashutosh Sharma <ashu.coek88@gmail.com>,
 Andres Freund <andres@anarazel.de>,
 pgsql-hackers <pgsql-hackers@postgresql.org>,
 Ajin Cherian <itsajin@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>
References: <CAJpy0uC+2agRtF3H=n-hW5JkoPfaZkjPXJr==y3_PRE04dQvhw@mail.gmail.com>
 <b254f365-d869-4cd2-887a-15da1bbcdaa3@gmail.com>
 <CAA4eK1+8k_yTsHmnExMQ3TWrAJ_KmPQwoze6DZ5OuQQhqK0wLw@mail.gmail.com>
 <538ddca6-cf74-4a9c-95d6-dd05af24070c@gmail.com>
 <CAA4eK1LbnX5Lu5-Zphv0=x8T+WnvSVoaDZHTY5RNk04dsymctA@mail.gmail.com>
 <dd9dbbaf-ca77-423a-8d62-bfc814626b47@gmail.com>
 <OS0PR01MB5716CE0729CEB3B5994A954194B3A@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <46070646-9e09-4566-8a62-ae31a12a510c@gmail.com>
 <CAJpy0uAT-oGsgmb4dC=dYYRNY7WXEAAWGWU2kL5phLz3Wcdifg@mail.gmail.com>
 <CAA4eK1J=-kPHS1eHNBtzOQHZ64j6WSgSYQZ3fH=2vfiwy_48AA@mail.gmail.com>
 <CAJpy0uB_y_1akXUWM9WnSdQ-NVWTnHTpmNu6gJQ5tnyuAMTUOg@mail.gmail.com>
 <CAHut+Pv-yu71ogj_hRi6cCtmD55bsyw7XTxj1Nq8yVFKpY3NDQ@mail.gmail.com>
 <OS0PR01MB571646B8186F6A06404BD50194BDA@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <OS0PR01MB57161C27BCFAF04C2B48B47394BDA@OS0PR01MB5716.jpnprd01.prod.outlook.com>
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: <OS0PR01MB57161C27BCFAF04C2B48B47394BDA@OS0PR01MB5716.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/65326908-f1ef-40ce-acc6-414801c30946%40gmail.com>
Precedence: bulk

Hi,

On 11/27/23 7:02 AM, Zhijie Hou (Fujitsu) wrote:
> On Monday, November 27, 2023 12:03 PM Zhijie Hou (Fujitsu) <houzj.fnst@fujitsu.com> wrote:
>>
>> Attach the V38 patch set which addressed all comments in [1][2] except for the
>> ones that mentioned above.
>>
>> [1]
>> https://www.postgresql.org/message-id/CAHut%2BPv-yu71ogj_hRi6cCtmD5
>> 5bsyw7XTxj1Nq8yVFKpY3NDQ%40mail.gmail.com
>> [2]
>> https://www.postgresql.org/message-id/CAHut%2BPuEGX5kr0xh06yv8ndoA
>> QvDNedoec1OqOq3GMxDN6p%3D9A%40mail.gmail.com
> 
> I didn't increment the patch version, sorry for that. Attach the same patch set
> but increment the patch version to V39.

Thanks!

It looks like v39 does not contain (some / all?) the changes that have been
done in v38 [1].

For example, slot_exists_in_list() still exists in v39 while it was renamed to
validate_sync_slot() in v38.

[1]: https://www.postgresql.org/message-id/CAJpy0uD6dWUvBgy8MGdugf_Am4pLXTL_vqcwSeHO13v%2BMzc9KA%40mail.gmail.com

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com