Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1sEcFZ-002Xfi-DC
	for pgsql-hackers@arkaria.postgresql.org; Tue, 04 Jun 2024 22:03:26 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.94.2)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1sEcFZ-002rYZ-6g
	for pgsql-hackers@arkaria.postgresql.org; Tue, 04 Jun 2024 22:03:25 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1sEcFY-002rYN-TN
	for pgsql-hackers@lists.postgresql.org; Tue, 04 Jun 2024 22:03:24 +0000
Received: from sss.pgh.pa.us ([68.162.161.243])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1sEcFW-003U0j-Jo
	for pgsql-hackers@lists.postgresql.org; Tue, 04 Jun 2024 22:03:23 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 454M3H1A653904;
	Tue, 4 Jun 2024 18:03:17 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Erik Wienhold <ewie@ewie.name>
cc: Pierre Forstmann <pierre.forstmann@gmail.com>,
        "a.kozhemyakin" <a.kozhemyakin@postgrespro.ru>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: pltcl crashes due to a syntax error
In-reply-to: <dc4d4bc0-6283-41dd-8e5d-5b9f4cf4fa4b@ewie.name>
References: <6a2a1c40-2b2c-4a33-8b72-243c0766fcda@postgrespro.ru> <CAM-sOH9zC5VeycS0BFCV4CAEfDL4OLEh_41oWtVLfbOZCtxNFw@mail.gmail.com> <5af13487-7722-4bdd-bad3-939598c8dd4e@ewie.name> <2365308.1717366548@sss.pgh.pa.us> <309214c5-d4da-4e00-938d-0e35990e564c@ewie.name> <73249.1717433869@sss.pgh.pa.us> <dc4d4bc0-6283-41dd-8e5d-5b9f4cf4fa4b@ewie.name>
Comments: In-reply-to Erik Wienhold <ewie@ewie.name>
	message dated "Mon, 03 Jun 2024 23:48:47 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <653902.1717538597.1@sss.pgh.pa.us>
Date: Tue, 04 Jun 2024 18:03:17 -0400
Message-ID: <653903.1717538597@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/653903.1717538597%40sss.pgh.pa.us>
Precedence: bulk

Erik Wienhold <ewie@ewie.name> writes:
> On 2024-06-03 18:57 +0200, Tom Lane wrote:
>> So your thought that we should just not use throw_tcl_error here
>> was correct, and a minimal fix could look like the attached.

> LGTM.

Pushed, thanks.

			regards, tom lane