Message-ID: <653b841d.a70a0220.17f72.2c12@mx.google.com>
Sender: Michael Banck <mbanck@gmail.com>
Date: Fri, 27 Oct 2023 11:34:20 +0200
From: Michael Banck <mbanck@gmx.net>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: David Burns <david.burns@fedex.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: Version 14/15 documentation Section "Alter Default Privileges"
References: <LV2PR12MB5725F7C1B8EB2FC38829F276E7399@LV2PR12MB5725.namprd12.prod.outlook.com>
 <4a6f157edc4ae38a2050a5893e6729cbb98113bc.camel@cybertec.at>
 <f898e097dbe5e718ec1a6e977d4dda79a6548abb.camel@cybertec.at>
 <a6671d5651e64fceff340c68dbdc41a9c5098748.camel@cybertec.at>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <a6671d5651e64fceff340c68dbdc41a9c5098748.camel@cybertec.at>
User-Agent: Mutt/1.10.1 (2018-07-13)
Archived-At: <https://www.postgresql.org/message-id/653b841d.a70a0220.17f72.2c12%40mx.google.com>
Precedence: bulk

Hi,

On Fri, Oct 27, 2023 at 09:03:04AM +0200, Laurenz Albe wrote:
> On Fri, 2022-11-04 at 10:49 +0100, Laurenz Albe wrote:
> > On Thu, 2022-11-03 at 11:32 +0100, Laurenz Albe wrote:
> > > On Wed, 2022-11-02 at 19:29 +0000, David Burns wrote:
> > > 
> > > > Some additional clarity in the versions 14/15 documentation
> > > > would be helpful specifically surrounding the "target_role"
> > > > clause for the ALTER DEFAULT PRIVILEGES command.  To the
> > > > uninitiated, the current description seems vague.  Maybe
> > > > something like the following would help:
> > 
> > After some more thinking, I came up with the attached patch.
> 
> I'm sending a reply to the hackers list, so that I can add the patch
> to the commitfest.

I think something like this is highly useful because I have also seen
people very confused why default privileges are not applied.

However, maybe it could be made even clearer if also the main
description is amended, like

"You can change default privileges only for objects that will be created
by yourself or by roles that you are a member of (via target_role)."

or something.


Michael