public inbox for [email protected]  

help / color / mirror / Atom feed

From: Michael Banck <[email protected]>
To: Laurenz Albe <[email protected]>
Cc: David Burns <[email protected]>
Cc: [email protected]
Subject: Re: Version 14/15 documentation Section "Alter Default Privileges"
Date: Sat, 28 Oct 2023 11:01:59 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <LV2PR12MB5725F7C1B8EB2FC38829F276E7399@LV2PR12MB5725.namprd12.prod.outlook.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Hi,

On Fri, Oct 27, 2023 at 05:49:42PM +0200, Laurenz Albe wrote:
> On Fri, 2023-10-27 at 11:34 +0200, Michael Banck wrote:
> > On Fri, Oct 27, 2023 at 09:03:04AM +0200, Laurenz Albe wrote:
> > > On Fri, 2022-11-04 at 10:49 +0100, Laurenz Albe wrote:
> > > > On Thu, 2022-11-03 at 11:32 +0100, Laurenz Albe wrote:
> > > > > On Wed, 2022-11-02 at 19:29 +0000, David Burns wrote:
> > > > > > Some additional clarity in the versions 14/15 documentation
> > > > > > would be helpful specifically surrounding the "target_role"
> > > > > > clause for the ALTER DEFAULT PRIVILEGES command.  To the
> > > > > > uninitiated, the current description seems vague.  Maybe
> > > > > > something like the following would help:
> > > > 
> > > > After some more thinking, I came up with the attached patch.
> > > 
> > I think something like this is highly useful because I have also seen
> > people very confused why default privileges are not applied.
> > 
> > However, maybe it could be made even clearer if also the main
> > description is amended, like
> > 
> > "You can change default privileges only for objects that will be created
> > by yourself or by roles that you are a member of (via target_role)."
> > 
> > or something.
> 
> True.  I have done that in the attached patch.
> In this patch, it is mentioned *twice* that ALTER DEFAULT PRIVILEGES
> only affects objects created by the current user.  I thought that
> would not harm, but if it is too redundant, I can remove the second
> mention.

I think it is fine, and I have marked the patch as ready-for-committer.

I think it should be applied to all branches, not just 14/15 as
mentioned in the subject.


Michael

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Version 14/15 documentation Section "Alter Default Privileges"
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox