Subject: Re: [PATCH] Tiny CREATE STATISTICS tab-completion cleanup
To: =?UTF-8?Q?Dagfinn_Ilmari_Manns=c3=a5ker?= <ilmari@ilmari.org>,
 pgsql-hackers@postgresql.org
References: <d8jwooziy1s.fsf@dalvik.ping.uio.no>
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Message-ID: <65551c69-46d4-305e-25fb-2e093454d660@2ndquadrant.com>
Date: Tue, 27 Nov 2018 00:55:35 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.0
MIME-Version: 1.0
In-Reply-To: <d8jwooziy1s.fsf@dalvik.ping.uio.no>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

On 11/26/18 5:49 PM, Dagfinn Ilmari Mannsåker wrote:
> Hi Hackers,
> 
> As I was hacking on the CREATE TABLE tab completions, I noticed that the
> CREATE STATISTICS completion was checking manually for the start and end
> of the parenthesised list instead of using the "(*)" wildcard (because
> it predates that functionality).  Attached is a patch that updates it to
> use the modern syntax.
> 

Makes sense. At first I was wondering why it was not modified by the
patch introducing the "(*)" wildcard, but I see 121213d9 only cared
about VACUUM, EXPLAIN and ANALYZE.

The patch seems fine to me, I'll get it committed.


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services