From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Justin Pryzby <pryzby@telsasoft.com>, Robert Haas <robertmhaas@gmail.com>,
        Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers@postgresql.org,
        Thomas Munro <thomas.munro@gmail.com>,
        Melanie Plageman <melanieplageman@gmail.com>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Daniel Gustafsson <daniel@yesql.se>
Subject: Re: Adding CI to our tree
In-reply-to: <20220119202926.nwbu5zfjts5qxbl4@alap3.anarazel.de>
References: 
 <CA+Tgmoap6WXzta=zw97SF73hCfzEWVMtfDFB01svYXMtTzKVVA@mail.gmail.com>
 <20220117192510.txue5mihjaxlngep@alap3.anarazel.de>
 <85428.1642447853@sss.pgh.pa.us>
 <20220117201619.3ltudwhgk2krmoki@alap3.anarazel.de>
 <20220118210847.GC23027@telsasoft.com>
 <20220119011626.nw5cvugqfsy3fyob@alap3.anarazel.de>
 <440239.1642560607@sss.pgh.pa.us>
 <20220119041646.rhuo3youiqxqjmo2@alap3.anarazel.de>
 <450972.1642568052@sss.pgh.pa.us> <647439.1642622744@sss.pgh.pa.us>
 <20220119202926.nwbu5zfjts5qxbl4@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 19 Jan 2022 12:29:26 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <656023.1642624990.1@sss.pgh.pa.us>
Date: Wed, 19 Jan 2022 15:43:10 -0500
Message-ID: <656024.1642624990@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/656024.1642624990%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> I'm doubtful that it's good that we use BAIL_OUT so liberally, because it
> prevents further tests from running (i.e. if 001 bails, 002+ doesn't run),
> which doesn't generally seem like the right thing to do after a single test
> fails. But that's really independent of the fix you make here.

Agreed, that's a separate question.  It does seem like "stop this script
and move to the next one" would be better behavior, though.

> I'd maybe do s/later/in the END block/ or such, so that one knows where to
> look. Took me a minute to find it again.

OK.

			regards, tom lane