Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewdWG-0004oO-Py for pgsql-hackers@arkaria.postgresql.org; Fri, 16 Mar 2018 00:46:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ewdWE-0006cd-Jd for pgsql-hackers@arkaria.postgresql.org; Fri, 16 Mar 2018 00:46:50 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1ewdWE-0006cT-3L for pgsql-hackers@lists.postgresql.org; Fri, 16 Mar 2018 00:46:50 +0000 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ewdWA-00045e-3v for pgsql-hackers@postgresql.org; Fri, 16 Mar 2018 00:46:48 +0000 Received: by mail-wm0-x22e.google.com with SMTP id u10so133504wmu.4 for ; Thu, 15 Mar 2018 17:46:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Kukzn9JUUSXi9CmZqiC1OK3+bJqP2ppPyUXUZrSr7Wo=; b=XxxL+BARTNzGucDCav+kvOvRdsJyFSRSI5y2H6TYil4HEaDw5AFz9t4CH4fiQ9Axsi vl8qJATzc9Pbun1q74QpflMUUFL8Vn4caAyWOsesKKlH8bVawu7nt9FCUxs8yzYXTx5v 2rfY1tdkd8aN/1RnGRuSE5Uhq7WxyQ33mWA9I0lS1ljHNu09zoznq4cXarjk6OFZtaRP 7FosXArr7gj8KCytPIT1db1qtIUizkAB/uvYlkNRmHuP7cP1Gz9021M5qpBsvwQiLYAV V232BHwtepRT4SxfPFcOsRekrgcpTvA2uRsRAvK44GbS3cqkujdZZNIXSPLkwMGA9UXB 9qWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Kukzn9JUUSXi9CmZqiC1OK3+bJqP2ppPyUXUZrSr7Wo=; b=mB2DsEX18ZbNWd+AWVfQiwUbfe1MCbHT7aQl0aZtQOU1IXO2DvWem7OBsnmdYmoDku nOgJn2M2YHYTKzTHI0KOGuV2YUwiQuSkE+a83YoGdQ4ewLdnWeUWyXNlswycT/X48cgc Ae3rbV9ShkiJXv6+vNDny63K4tj3BP/hsHSxBtVbj1sOcy87PORnK878FIKTtucMNJUc YiqMOuUc6RJNRuPThQq948t1qZRsGN0wb0YuvGqvFS1nM530mYfw6Y5lHq8KLKAPMM6W Lrr6KveSIOi+CCMOQWK32aOPnQ7JLJeuJ7dxYRwi9upW6/WrlRz11aUil6t4q2G0Rw4n F7uA== X-Gm-Message-State: AElRT7GQ5Zn44/3AYLDautC+lL32Gr6MnF0U63shFdgvizuMa6AW7Cka KyQllpAzx49PZzCYJzN+LjJjEE4i6bU/7Suk6YvGZ64XI5FvxeYE2fggPDTjxGcs18J7jJKkGDR FKf5Iu7eCpSckq+TWQplnnffxc4gIzbLlAbjKqyzME1E1h5hL0hu9YA7pEH8cwtLMJa20UhMOWM KCJMLwsNbs X-Google-Smtp-Source: AG47ELsmHhzThux1Mq1rNlLdA2iIk7Pq+AROGzWHbuBrHHDOZOdFC9vAOIOeKvIxAwi9HHtD5XmNSA== X-Received: by 10.28.74.88 with SMTP id x85mr202857wma.106.1521161203746; Thu, 15 Mar 2018 17:46:43 -0700 (PDT) Received: from [10.137.2.19] (ip-78-102-97-226.net.upcbroadband.cz. [78.102.97.226]) by smtp.gmail.com with ESMTPSA id r6sm7020749wrg.63.2018.03.15.17.46.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Mar 2018 17:46:42 -0700 (PDT) Subject: Re: Parallel Aggregates for string_agg and array_agg From: Tomas Vondra To: David Rowley Cc: Andres Freund , PostgreSQL-development References: <20180301212631.kede4nyuttzxwoxq@alap3.anarazel.de> <24abe018-b3c6-2117-b5b9-39e660db00bd@2ndquadrant.com> <1b6ee15c-c218-761e-0120-c1ed438e2db2@2ndquadrant.com> Message-ID: <657be73a-a21d-0ae1-5c62-870afbdfddd4@2ndquadrant.com> Date: Fri, 16 Mar 2018 01:46:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1b6ee15c-c218-761e-0120-c1ed438e2db2@2ndquadrant.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 03/11/2018 12:10 PM, Tomas Vondra wrote: > > ... > > Yeah, seems fine to me. I wonder what else would be needed before > switching the patch to RFC. I plan to do that after a bit more > testing sometime early next week, unless someone objects. > I've done more testing on this patch, and I haven't found any new issues with it, so PFA I'm marking it as ready for committer. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services