Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZhbA-0003F9-Tu for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Mar 2022 23:19:33 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZhb9-0008I0-QH for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Mar 2022 23:19:31 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZhb9-0008HL-4S for pgsql-hackers@lists.postgresql.org; Wed, 30 Mar 2022 23:19:31 +0000 Received: from mail-ed1-x536.google.com ([2a00:1450:4864:20::536]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nZhb6-0004q8-07 for pgsql-hackers@lists.postgresql.org; Wed, 30 Mar 2022 23:19:30 +0000 Received: by mail-ed1-x536.google.com with SMTP id g22so15131728edz.2 for ; Wed, 30 Mar 2022 16:19:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=/AzrzS+5jzjWt8xKx/KH3M+mSWT7z5ZYakYkmVwDQQU=; b=Goe4dp5LJYvzx+a23AvDa10yO+i2zeubdQUgt4YmUIf6xvSyIx53vVkkKZ+5m1xEp4 O6AWtfMTVYNWT8MQ816XIP/nyc4XIMiDIs/tzFMzKtDe+M/UnYtygpSBvXfJclETLKAy PE7fTaDYjXSDziHvYsxpwXy18uEkIDtvFcJbJWygkkiNREiQvKtRlrs/ZIjlJZrkOoZR LKaoD0NoL+Ec24puZ+yP/c4i6Uhi9ba4RJhasgjzFrG+t53jCI9pEJC0hQxcpEoQyu10 fb9CNOeuaYrGNUONtXG5q0Zdl5y2h5rCvBuQ85d4q2mJlctrTUwtB7F9zbHSVpFUUzlR AFlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=/AzrzS+5jzjWt8xKx/KH3M+mSWT7z5ZYakYkmVwDQQU=; b=Zct2yV+slPqDYL9IysC2hJTi9JeBW5VKAVdl8ZvqMmfzs/30js6Mm4IHGAAq7/S0R/ mLZVLwfE1I5T33k98OTahYHQPWM02qJYqfPofEwnLAxb3fgydQ2uehLKU+IB9F+EwxDg JsY6zjwCpoeUb9YUNBshGQ/Jg+nP4qwMHLL95eJwDAf0W04yJ0mwKdVh1Jl2glYMVrJ1 mZaDbDN2Z0xnSw6c0cgRR14aVmzs80Xb9mN5J3HfeZhr0eLnggPYgqEINyxckkHZ/OF6 iV09DBdgPdxjE3akr7G1hd/2OZbEJhPQY8L+vgQkwHndK+gDMNnGRsYWGsCUrEfWpgS5 zcFg== X-Gm-Message-State: AOAM533WDg2A+PLDlJ+zh6ZMdh19C9/2rzFf5rpjTVsisw4//Fszdp07 bEj7xq/ffa7VtR2rRLQLtO5ERlgaBzyq98IlN7PmIK+M+mhKxI2S7wQoMzIvONr3e0NXHIuivCg Sk0y4bvLZ4mCXuT1uiDjs0vo73TErMn5vekN/ZoIsRgB7yeSnTTv0Z2+ApaTygwhyGJKY45Elag pe9hzp9qOkpbqMPd/W6OGv+zz2a12nS1FSqA8jiRix7iJg3erqCsHa X-Google-Smtp-Source: ABdhPJzYTQhZFBXAmJlqTCAbIAnn6k7AWHMEqBaLgp7tfxGzR+3IV39SqhWYmzLg11lTBdaB4nQ23A== X-Received: by 2002:aa7:d5d7:0:b0:418:f7b0:88cc with SMTP id d23-20020aa7d5d7000000b00418f7b088ccmr13591301eds.227.1648682366076; Wed, 30 Mar 2022 16:19:26 -0700 (PDT) Received: from [10.137.0.17] (ip-86-49-250-165.net.upcbroadband.cz. [86.49.250.165]) by smtp.gmail.com with ESMTPSA id d11-20020a170906c20b00b006d584a09b9fsm8879841ejz.98.2022.03.30.16.19.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Mar 2022 16:19:25 -0700 (PDT) Message-ID: <65941e87-86c1-c09c-8ad5-8e102aebe8ee@enterprisedb.com> Date: Thu, 31 Mar 2022 01:19:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: POC: GROUP BY optimization Content-Language: en-US To: Zhihong Yu Cc: "Andrey V. Lepikhov" , Teodor Sigaev , Tomas Vondra , PostgreSQL Developers References: <22c44f98-bfa8-8630-62b5-5155e11eb284@enterprisedb.com> <006667af-fc50-0627-4be7-5d9cf665219f@enterprisedb.com> <4ee5b15c-1ce0-59c7-8d4a-a1fd68ee0d12@postgrespro.ru> <721b3ff9-f214-f5d4-86c7-bae515bbec18@enterprisedb.com> <7bea462e-8c3e-0f8c-c7d5-f4daa12f3baf@postgrespro.ru> <9af89543-3d17-4c98-59de-1daa5bceeb06@enterprisedb.com> <9408e450-60c6-6fbc-d5c4-467bb0abfe67@postgrespro.ru> <44472925-f6c6-e8de-6f72-0451458532c4@enterprisedb.com> <7a80a207-5e8e-b80c-476c-2d290b0526e9@enterprisedb.com> From: Tomas Vondra In-Reply-To: <7a80a207-5e8e-b80c-476c-2d290b0526e9@enterprisedb.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Pushed, after going through the patch once more, running check-world under valgrind, and updating the commit message. Thanks to everyone who reviewed/tested this patch! -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company