Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\))
Subject: Re: Fix SET EXPRESSION for virtual columns with whole-row
 dependencies
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CACJufxHaErSjsxkhMJVS9zuGvrgej831ibieAvn1+1o-GQ8dFg@mail.gmail.com>
Date: Sat, 13 Jun 2026 14:01:40 +0800
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>,
 Peter Eisentraut <peter@eisentraut.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <65A70B05-E682-48AE-9EB2-D62ADBFB35D1@gmail.com>
References: <71242FEA-15A3-4073-9FA1-561CA744ACBD@gmail.com>
 <CACJufxHTK0Qk7AwdrHK=y8OtK--zEVY-Ossxx4UUgxaE2NCAXA@mail.gmail.com>
 <5B739323-C897-4B1A-9BFC-656E5CB4AD58@gmail.com>
 <B28E88B4-F8AA-40BA-A087-12BB9348B1E0@gmail.com>
 <CACJufxHaErSjsxkhMJVS9zuGvrgej831ibieAvn1+1o-GQ8dFg@mail.gmail.com>
To: jian he <jian.universality@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/65A70B05-E682-48AE-9EB2-D62ADBFB35D1%40gmail.com>
Precedence: bulk


> On Jun 13, 2026, at 10:42, jian he <jian.universality@gmail.com> =
wrote:
>=20
> On Wed, Jun 10, 2026 at 5:06=E2=80=AFPM Chao Li =
<li.evan.chao@gmail.com> wrote:
>>=20
>>=20
>> After reading the other implementation in [1], I realized that I had =
missed the partial-index case, so I added coverage for that.
>>=20
>> I am still sending an updated version of this patch because my =
implementation is different from the one in [1]. I would like people to =
compare the two approaches and decide which direction is better.
>>=20
>=20
> I tried your patch before but abandoned it due to many regression test =
failures.
>=20

Thanks for looking. But I wonder which tests I missed?

I ran =E2=80=9Cmake check-world=E2=80=9D locally and passed. The CI =
tests all passed on the CF: =
https://commitfest.postgresql.org/patch/6867/

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/