Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rT7GG-000Y83-MO for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Jan 2024 21:27:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rT7GE-004OEe-WB for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Jan 2024 21:27:47 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rT7GE-004OEN-N0 for pgsql-hackers@lists.postgresql.org; Thu, 25 Jan 2024 21:27:46 +0000 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rT7GC-003Mff-4x for pgsql-hackers@lists.postgresql.org; Thu, 25 Jan 2024 21:27:45 +0000 Received: by mail-qk1-x72f.google.com with SMTP id af79cd13be357-783c9165218so17701085a.1 for ; Thu, 25 Jan 2024 13:27:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dunslane-net.20230601.gappssmtp.com; s=20230601; t=1706218063; x=1706822863; darn=lists.postgresql.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EBlccbR7aefL59rycInEt5IftXnWP09gU8Ci37T7Vc8=; b=Vzfvx+zb3HrIGp8J7p01FCBWWoWxWvcFJk1hikf/XpBP1WypP4PT3TwkaNkqNdikWm JuoyR0yQmGfsOTgAFd37ERLsH7538CB7OFkVYRPhD35654ArSwNAR8qkI1bkJSgI87zl XVoPYw5TqNmgg1p2awEWX7+m0tV9Xtkcn0VOW4fS0ysS3b8E8tG2HGGNl9Q8rFfwb/4d 5iXOHCbfpiXThvatwvOoMyo2NC+rYwAvSfCGcMjSOYYQl80mjOdZpOhHHgz8DXkAHny5 fdIgDj/rfp7BWSAZcLy39WbbY3XcC22G+ROdijWRlEjZZPwVpJ1TXyirtqfH4zEldEwl Ve8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706218063; x=1706822863; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EBlccbR7aefL59rycInEt5IftXnWP09gU8Ci37T7Vc8=; b=Ho7hyLMjQnj6MYHNx+uyohIDSPwHcH2QkkDfl+v7ZAtzydIKJq+INbSBUYYIRgXvHq /2aGLAv22MayvEwbnX3OIJPMdddn0dVbTQobtwsynNWRcG+rt+qaeVO9T1ePL9yfq/iq Q9I+2Hvdykb+ypo2kdPmzP3SdpCyvm+4lW7lm58jl68Zu9Nh4EhQSn7So8+mKxDfHb1g sms9UH81eieH1rvW/wON7NIUNSpJC0t4DDavU0IbxO0TRYBtD9YcsQbVGeFkzMSsl6QC FPBfT8+DTKkH0ip49M3ILuxZ6S58mgpH0Cw6uWGLOggnP7Vq8bIfn5gh57GMXR2bKTEN Pw7Q== X-Gm-Message-State: AOJu0YwjEqytgGKgnvNvjJ+fnrYuwMqphY1uL0OUiWS7oy+kfe3uonCe 1O66w4VXD1Q1t1pfBZZ/D+ugo+mVy6Ehuck9MLNNkjgtea2TWWo4a4duxLsAqV0= X-Google-Smtp-Source: AGHT+IE+3WGxftGxoHUPYGGO2TuSfSY7IrqcLBMCNB2HjvY0e5xaPLViSNklPzl7U19h5iyPitrglQ== X-Received: by 2002:a05:620a:260c:b0:783:4195:90e7 with SMTP id z12-20020a05620a260c00b00783419590e7mr429566qko.46.1706218063042; Thu, 25 Jan 2024 13:27:43 -0800 (PST) Received: from ?IPV6:2605:a601:91f3:1900::2bb? ([2605:a601:91f3:1900::2bb]) by smtp.googlemail.com with ESMTPSA id x11-20020ae9e90b000000b007832575779esm5394485qkf.52.2024.01.25.13.27.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jan 2024 13:27:42 -0800 (PST) Message-ID: <65ac43de-8abe-f9ef-1fe8-838ea22e9c45@dunslane.net> Date: Thu, 25 Jan 2024 16:27:41 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: More new SQL/JSON item methods Content-Language: en-US To: Tom Lane Cc: Jeevan Chalke , Peter Eisentraut , PostgreSQL Hackers References: <1d092c02-8249-4e56-8b8e-ae4db95b8fde@eisentraut.org> <5d37428e-0753-e721-8e77-81cc4d0dc9f1@dunslane.net> <439811.1706211069@sss.pgh.pa.us> <448055.1706214831@sss.pgh.pa.us> <451195.1706216300@sss.pgh.pa.us> From: Andrew Dunstan In-Reply-To: <451195.1706216300@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2024-01-25 Th 15:58, Tom Lane wrote: > I wrote: >> There's something else going on, because I'm still getting the >> assertion failure on my Mac with this fix in place. Annoyingly, >> it goes away if I compile with -O0, so it's kind of hard to >> identify what's going wrong. > No, belay that: I must've got confused about which version I was > testing. It's very unclear to me why the undefined reference > causes the preceding Assert to misbehave, but that is clearly > what's happening. Compiler bug maybe? My Mac has clang 15.0.0, > and the unhappy buildfarm members are also late-model clang. > > Anyway, I did note that the preceding line > > res = jperOk; > > is dead code and might as well get removed while you're at it. > > OK, pushed those. Thanks. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com