Message-ID: <65b146b9.170a0220.c645b.0891@mx.google.com>
Sender: Michael Banck <mbanck@gmail.com>
Date: Wed, 24 Jan 2024 18:19:53 +0100
From: Michael Banck <mbanck@gmx.net>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Set log_lock_waits=on by default
References: <b8b8502915e50f44deb111bc0b43a99e2733e117.camel@cybertec.at>
 <659ffa38.170a0220.eea6a.28fc@mx.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <659ffa38.170a0220.eea6a.28fc@mx.google.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Archived-At: 
 <https://www.postgresql.org/message-id/65b146b9.170a0220.c645b.0891%40mx.google.com>
Precedence: bulk

Hi,

On Thu, Jan 11, 2024 at 03:24:55PM +0100, Michael Banck wrote:
> On Thu, Dec 21, 2023 at 02:29:05PM +0100, Laurenz Albe wrote:
> > Here is a patch to implement this.
> > Being stuck behind a lock for more than a second is almost
> > always a problem, so it is reasonable to turn this on by default.
> 
> I also think that this should be set to on.
> 
> I had a look at the patch and it works fine. 
>
> Regarding the documentation, maybe the back-reference at
> deadlock_timeout could be made a bit more explicit then as well, as in
> the attached patch, but this is mostly bikeshedding.

I've marked it ready for committer now, as the above really is
bikeshedding.


Michael