Message-ID: <65b620bd-4f05-4381-97c3-5ec9ac39d5b9@postgresfriends.org>
Date: Fri, 13 Oct 2023 07:03:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Add support for AT LOCAL
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: cary huang <hcary328@gmail.com>, pgsql-hackers@lists.postgresql.org
References: <8e25dec4-5667-c1a5-6581-167d710c2182@postgresfriends.org>
 <b274179d-2121-68f3-7cd9-c5a572f8fd83@postgresfriends.org>
 <169541920143.2315938.17412414971559687288.pgcf@coridan.postgresql.org>
 <dbea9877-f39b-1a5b-6e5b-5aad2bbc2821@postgresfriends.org>
 <ZRZ8ePmlhx_1LvVV@paquier.xyz>
 <c2c6f2c3-49e3-c1fe-65ca-49f275af41c2@postgresfriends.org>
 <ZR-jmKYU5BDQEAe4@paquier.xyz>
 <e3b4c42d-739d-4375-9401-2f62ad59d326@postgresfriends.org>
 <ZSTUWON7DOfo-2ES@paquier.xyz>
 <a2bd6444-7fe4-44cd-8cb6-d7ac13f4d3e0@postgresfriends.org>
 <ZSjCZJrxGL0-wv-G@paquier.xyz>
From: Vik Fearing <vik@postgresfriends.org>
In-Reply-To: <ZSjCZJrxGL0-wv-G@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/65b620bd-4f05-4381-97c3-5ec9ac39d5b9%40postgresfriends.org>
Precedence: bulk

On 10/13/23 05:07, Michael Paquier wrote:
> On Fri, Oct 13, 2023 at 02:20:59AM +0200, Vik Fearing wrote:
>> On 10/10/23 05:34, Michael Paquier wrote:
>>> I am attaching a v5 that addresses the documentation bits, could you
>>> look at the business with date.c?
>>
>> Here is a v6
> 
> Thanks for the new version.
> 
>> which hopefully addresses all of your concerns.
> 
> Mostly ;)
> 
> The first thing I did was to extract the doc bits about timezone(zone,
> time) for AT TIME ZONE from v6 and applied it independently.
> 
> I have then looked at the rest and it looked mostly OK to me,
> including the extra description you have added for the fifth example
> in the docs.  I have tweaked a few things: the regression tests to
> make the views a bit more appealing to the eye, an indentation to not
> have koel complain and did a catalog bump.  Then applied it.


Thank you, Michael君!
-- 
Vik Fearing