Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIhv3-00049N-MO for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Sep 2020 00:37:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kIhv2-00080E-7F for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Sep 2020 00:37:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIhv2-000807-0i for pgsql-hackers@lists.postgresql.org; Thu, 17 Sep 2020 00:37:00 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIhuz-0004c2-Og for pgsql-hackers@lists.postgresql.org; Thu, 17 Sep 2020 00:36:59 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 08H0atc2066006; Wed, 16 Sep 2020 20:36:55 -0400 From: Tom Lane To: Alvaro Herrera cc: Michael Paquier , pgsql-hackers@lists.postgresql.org Subject: Re: Gripes about walsender command processing In-reply-to: <20200917001926.GA28698@alvherre.pgsql> References: <20200917001926.GA28698@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Wed, 16 Sep 2020 21:19:26 -0300" MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-ID: <66004.1600303015.1@sss.pgh.pa.us> Content-Transfer-Encoding: 8bit Date: Wed, 16 Sep 2020 20:36:55 -0400 Message-ID: <66005.1600303015@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Alvaro Herrera writes: > On 2020-Sep-16, Tom Lane wrote: >> Note that your changes need to be backpatched into v13, >> because AFAICS this code is violating the FE/BE protocol >> right now --- it's just luck that libpq isn't moaning >> about extra CommandComplete messages. But I don't think >> we want to change the ps title behavior in v13 at this >> late date, so that part should be HEAD-only. > I pushed to 13, but it's because of the removal of the command tag; the > duplicate tags we've been sending since 9.3. ¯\_(ツ)_/¯ Ugh. Well, fixing v13 is an improvement anyway. Thanks! regards, tom lane