Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M334547=pgsql-hackers-arkari@postgresql.org>)
	id 1dovSk-0006YH-RM
	for pgsql-hackers@arkaria.postgresql.org; Mon, 04 Sep 2017 17:47:06 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-hackers-owner+M334547=pgsql-hackers-arkari@postgresql.org>)
	id 1dovSk-00055y-E3
	for pgsql-hackers@arkaria.postgresql.org; Mon, 04 Sep 2017 17:47:06 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1dovSj-000550-FW
	for pgsql-hackers@postgresql.org; Mon, 04 Sep 2017 17:47:05 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1dovSc-0007JE-TC
	for pgsql-hackers@postgresql.org; Mon, 04 Sep 2017 17:47:04 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v84Hkque006612;
	Mon, 4 Sep 2017 13:46:52 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tatsuo Ishii <ishii@sraoss.co.jp>
cc: coelho@cri.ensmp.fr, rafia.sabih@enterprisedb.com,
        michael.paquier@gmail.com, Langote_Amit_f8@lab.ntt.co.jp,
        robertmhaas@gmail.com, pavel.stehule@gmail.com,
        pgsql-hackers@postgresql.org
Subject: Re: pgbench - allow to store select results into variables
In-reply-to: <20170420.170640.2147960429835861950.t-ishii@sraoss.co.jp>
References: <alpine.DEB.2.20.1704171524050.4025@lancre>
 <20170417.181123.1539611157606514675.t-ishii@sraoss.co.jp>
 <alpine.DEB.2.20.1704171959080.1741@lancre>
 <20170420.170640.2147960429835861950.t-ishii@sraoss.co.jp>
Comments: In-reply-to Tatsuo Ishii <ishii@sraoss.co.jp>
	message dated "Thu, 20 Apr 2017 17:06:40 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6610.1504547212.1@sss.pgh.pa.us>
Date: Mon, 04 Sep 2017 13:46:52 -0400
Message-ID: <6611.1504547212@sss.pgh.pa.us>
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Tatsuo Ishii <ishii@sraoss.co.jp> writes:
>> Here is a v3 with a more precise comment.

> Looks good to me. I have marked the patch status as "Ready for
> committer".

LGTM too.  Pushed with a minor adjustment to make parseVariable()
have exactly the same test as valid_variable_name().

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers