Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dW0xP-0006Nz-60 for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Jul 2017 13:48:35 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dW0xO-0003OB-Iq for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Jul 2017 13:48:34 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dW0xN-0003NG-Cn for pgsql-hackers@postgresql.org; Fri, 14 Jul 2017 13:48:33 +0000 Received: from mail.postgrespro.ru ([93.174.131.138]) by magus.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dW0xJ-0001nO-TN for pgsql-hackers@postgresql.org; Fri, 14 Jul 2017 13:48:32 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.postgrespro.ru (Postfix) with ESMTP id 7B3A021C03C2; Fri, 14 Jul 2017 16:48:29 +0300 (MSK) X-Virus-Scanned: Debian amavisd-new at postgrespro.ru MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1500040109; bh=4CW3pzQJC7wSdGY50Oz7mYjMKXtzXrzmHaLoH83qmQo=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=H+zQKvwoDR/VF38OIKtL3r4PkzIDl70WOTHLE4t7UBrJ6ItAMVOvPlnXse/96lgKo y3U86zoLljKcPFnv0kE/U6v5M4u0Aq+BqXPv9uIY+vFgUcx6fGz6Xvaug/b0X8dVGC aF/GeAogLoxg6gIYG/KvjA9MzKtfmyeiuEbqkc7M= Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 14 Jul 2017 16:48:29 +0300 From: Marina Polyakova To: Fabien COELHO Cc: PostgreSQL Developers , Kevin Grittner , Andres Freund , Alvaro Herrera , Thomas Munro , Robert Haas Subject: Re: WIP Patch: Pgbench Serialization and deadlock errors Organization: Postgres Professional In-Reply-To: References: <72a0d590d6ba06f242d75c2e641820ec@postgrespro.ru> <6b4a7fb36c9956595a89a08e5368a9c5@postgrespro.ru> <01df6ca86c78e2c80b4e4d021c99d53a@postgrespro.ru> <898b57f7c12b6bd0484f8ca58fdf8436@postgrespro.ru> Message-ID: <66193a3704fe466e0ef4812302712bc8@postgrespro.ru> X-Sender: m.polyakova@postgrespro.ru User-Agent: Roundcube Webmail/1.2.4 List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org > Given that the number of variables of a pgbench script is expected to > be pretty small, I'm not sure that the sorting stuff is worth the > effort. I think it is a good insurance if there're many variables.. > My suggestion is really to look at both implementations and to answer > the question "should pgbench share its variable implementation with > psql?". > > If the answer is yes, then the relevant part of the implementation > should be moved to fe_utils, and that's it. > > If the answer is no, then implement something in pgbench directly. The structure of variables is different, the container structure of the variables is different, so I think that the answer is no. -- Marina Polyakova Postgres Professional: http://www.postgrespro.com The Russian Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers