From: Tom Lane <tgl@sss.pgh.pa.us>
To: emre@hasegeli.com
cc: =?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
        Andrew Dunstan <andrew@dunslane.net>,
        Matthias Kurz <m.kurz@irregular.at>,
        Jim Nasby <Jim.Nasby@bluetreble.com>,
        "David G. Johnston" <david.g.johnston@gmail.com>
Subject: Re: [PATCH] Alter or rename enum value
In-reply-to: 
 <CAE2gYzxo4bB_uQDafQYoGx=WmUrO-NFUbKBYfu4j_=LfaaUzFg@mail.gmail.com>
References: 
 <CAO=2mx6uvgPaPDf-rHqG8=1MZnGyVDMQeh8zS4euRyyg4D35OQ@mail.gmail.com>
 <56E049CC.8010201@dunslane.net> <25605.1457539654@sss.pgh.pa.us>
 <56E05635.70908@dunslane.net> <28167.1457543612@sss.pgh.pa.us>
 <CAO=2mx4rQHRvifT2yUQ1rz90A=9CVz4_Z0Sx1wTgwgQRzAimpQ@mail.gmail.com>
 <CAO=2mx6rK_h4BC7y+3Nu-8fuZJXdFjd9FE_MZnzkH+vnMp0C-Q@mail.gmail.com>
 <d8ja8ln7nl0.fsf@dalvik.ping.uio.no> <d8jk2kn4yn0.fsf_-_@dalvik.ping.uio.no>
 <d8jeg5m4as8.fsf@dalvik.ping.uio.no>
 <CAE2gYzxo4bB_uQDafQYoGx=WmUrO-NFUbKBYfu4j_=LfaaUzFg@mail.gmail.com>
Comments: In-reply-to Emre Hasegeli <emre@hasegeli.com>
	message dated "Sun, 21 Aug 2016 15:49:16 +0200"
Date: Sun, 21 Aug 2016 10:28:18 -0400
Message-ID: <6629.1471789698@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Emre Hasegeli <emre@hasegeli.com> writes:
>> +        ReleaseCatCacheList(list);
>> +        heap_close(pg_enum, RowExclusiveLock);

> Maybe we better release them before reporting error, too.  I would
> release the list after the loop, close the heap before ereport().

Transaction abort will clean up such resources just fine; if it did
not, then any function you call would have problems if it threw an
error.  I would not contort the logic to free stuff before ereport.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers