public inbox for [email protected]  

help / color / mirror / Atom feed

From: Heikki Linnakangas <[email protected]>
To: Andres Freund <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Alexander Kuzmenkov <[email protected]>
Cc: Ashutosh Sharma <[email protected]>
Subject: Re: Assertion failure in hash_kill_items()
Date: Tue, 7 Apr 2026 17:38:36 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <p45puiwvjtbeff6cx2suwk3i35zubdot6iaa3z6buiqnoix7v6@hzygqumsgome>
References: <[email protected]>
	<p45puiwvjtbeff6cx2suwk3i35zubdot6iaa3z6buiqnoix7v6@hzygqumsgome>

On 17/03/2026 19:40, Andres Freund wrote:
> On 2026-03-17 19:15:10 +0200, Heikki Linnakangas wrote:
>> The second patch simplifies the condition in the 'unlock_page' part. This
>> isn't new, and isn't needed to fix the bug, it just caught my eye while
>> looking at this. I don't understand why the condition was the way it was,
>> checking just 'havePin' seems sufficient and more correct to me. Am I
>> missing something?
> 
> I can't see anything either, quite odd.  Most likely explanation seems to be
> that something changed during the development of 7c75ef571579.
> 
> 
> Indeed, the first version of the patch from
>     https://postgr.es/m/CAE9k0Pm3KTx93K8_5j6VMzG4h5F%2BSyknxUwXrN-zqSZ9X8ZS3w%40mail.gmail.com
> was using "if (so->hashso_bucket_buf == so->currPos.buf)" both at the start
> and end of _hash_kill_items(). So likely it was just an accident during patch
> revisions.

Thanks for archeological excavation; pushed this second patch now.

- Heikki

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Assertion failure in hash_kill_items()
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox