From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas@vondra.me>
cc: Daniel Gustafsson <daniel@yesql.se>,
        Evgeniy Gorbanev <gorbanyoves@basealt.ru>,
        pgsql-hackers@lists.postgresql.org
Subject: Re: No error checking when reading from file using zstd in pg_dump
In-reply-to: <f2dec453-b6af-4495-a75d-a39628411510@vondra.me>
References: <6b9817a8-88ec-4efd-b441-9e2a0439c6b8@basealt.ru>
 <C22FF2A1-783D-4334-998B-2D4432EFD7C5@yesql.se>
 <95255a86-4bc7-4ff4-aa26-4441aafdf0fb@basealt.ru>
 <522DB522-3962-4F91-A691-2DE790F6CCD6@yesql.se>
 <b653a2f4-1dcb-45ba-b899-fc6aa80794f2@basealt.ru>
 <D38B293E-E886-4F0D-BD5A-C958DCB2344C@yesql.se>
 <e2b7edd1-c5b8-484d-9c79-7a7c4466fad2@basealt.ru>
 <517794.1750082166@sss.pgh.pa.us>
 <3815B6CD-924B-40FA-823A-55E2F8F24602@yesql.se>
 <520142.1750083607@sss.pgh.pa.us>
 <D011594F-7FA3-4BE4-BF89-B1AB18CD3456@yesql.se>
 <644360.1750096605@sss.pgh.pa.us>
 <f2dec453-b6af-4495-a75d-a39628411510@vondra.me>
Comments: In-reply-to Tomas Vondra <tomas@vondra.me>
	message dated "Mon, 16 Jun 2025 22:23:46 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <666034.1750106940.1@sss.pgh.pa.us>
Date: Mon, 16 Jun 2025 16:49:00 -0400
Message-ID: <666035.1750106940@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/666035.1750106940%40sss.pgh.pa.us>
Precedence: bulk

Tomas Vondra <tomas@vondra.me> writes:
> For a moment I was worried about breaking ABI when fixing this in the
> backbranches, but I guess that's not an issue for tools like pg_dump.

Yeah, I think it'd be okay to change compress_io.h APIs in the back
branches; it's hard to see how anything outside pg_dump+pg_restore
would be depending on that.

			regards, tom lane