From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
        =?UTF-8?Q?J=c3=bcrgen_Strobel?= <juergen+postgresql@strobel.info>,
        Amit Langote <amitlangote09@gmail.com>,
        Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: BUG #15212: Default values in partition tables don't work as
 expected and allow NOT NULL violation
In-reply-to: <f45328d3-70ef-2186-fd6d-6ec58e3d951f@lab.ntt.co.jp>
References: <20181109170712.pfn55lab5j7oae4v@alvherre.pgsql>
 <29152.1541802819@sss.pgh.pa.us>
 <f45328d3-70ef-2186-fd6d-6ec58e3d951f@lab.ntt.co.jp>
Comments: In-reply-to Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
	message dated "Mon, 12 Nov 2018 11:47:27 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6675.1541995199.1@sss.pgh.pa.us>
Date: Sun, 11 Nov 2018 22:59:59 -0500
Message-ID: <6676.1541995199@sss.pgh.pa.us>
Precedence: bulk

Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> writes:
> On 2018/11/10 7:33, Tom Lane wrote:
>> I'd argue not, actually.  I think there is plausible precedent in
>> updatable views, where what we use is the defaults associated with the
>> view, not the underlying table.  Correspondingly, what ought to govern
>> in a partitioned insert is the defaults associated with the table actually
>> named in the insert command, never mind what its partitions might say.
>> That is useful for many situations, and it avoids all the logical
>> inconsistencies you get into if you find that the defaults associated
>> with some partition would force re-routing elsewhere.

> ...
> IOW, it might be a good idea to call the ability to set partition-level
> defaults a deprecated feature?

Not necessarily.  They'd apply when you insert directly into a particular
partition by name.

			regards, tom lane