Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1q17YD-000765-Re
	for pgsql-hackers@arkaria.postgresql.org; Mon, 22 May 2023 15:34:21 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1q17YC-00063I-Oj
	for pgsql-hackers@arkaria.postgresql.org; Mon, 22 May 2023 15:34:20 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1q17YC-000639-FG
	for pgsql-hackers@lists.postgresql.org; Mon, 22 May 2023 15:34:20 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1q17YA-001EXd-2v
	for pgsql-hackers@postgresql.org; Mon, 22 May 2023 15:34:19 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 34MFYEY2668370;
	Mon, 22 May 2023 11:34:14 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Tristan Partin" <tristan@neon.tech>
cc: "Alvaro Herrera" <alvherre@alvh.no-ip.org>, pgsql-hackers@postgresql.org
Subject: Re: Add missing includes
In-reply-to: <CSSWUW8WKFLW.3VJGFG2LZYEBM@c3po>
References: <CSSWHSSN4B6S.14UNR4TB14WOU@c3po> <20230522151657.vincyjdi56uedfhk@alvherre.pgsql> <CSSWUW8WKFLW.3VJGFG2LZYEBM@c3po>
Comments: In-reply-to "Tristan Partin" <tristan@neon.tech>
	message dated "Mon, 22 May 2023 10:27:37 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <668368.1684769654.1@sss.pgh.pa.us>
Date: Mon, 22 May 2023 11:34:14 -0400
Message-ID: <668369.1684769654@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/668369.1684769654%40sss.pgh.pa.us>
Precedence: bulk

"Tristan Partin" <tristan@neon.tech> writes:
> Interesting. Thanks for the information. Thought I had seen in a
> different email thread that header files were supposed to include all
> that they needed to. Anyways, ignore the patch :).

There is such a policy, but not with respect to those particular
headers.  You might find src/tools/pginclude/headerscheck and
src/tools/pginclude/cpluspluscheck to be interesting reading,
as those are the tests we run to verify this policy.

			regards, tom lane