From: Chao Li <li.evan.chao@gmail.com>
Message-Id: <66A28678-BDC0-4266-9244-74320D578222@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_3BDFC205-B40A-4D0A-8D5A-4CDC9A76CF7D"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options
Date: Sat, 11 Oct 2025 13:57:58 +0800
In-Reply-To: <20251011.144218.1729318385118014326.ishii@postgresql.org>
Cc: tgl@sss.pgh.pa.us,
 pramsey@cleverelephant.ca,
 ojford@gmail.com,
 peter@eisentraut.org,
 krasiyan@gmail.com,
 vik@postgresfriends.org,
 andrew@tao11.riddles.org.uk,
 david@fetter.org,
 pgsql-hackers@lists.postgresql.org
To: Tatsuo Ishii <ishii@postgresql.org>
References: <20251008.093117.1326499841464447981.ishii@postgresql.org>
 <2952409.1760023154@sss.pgh.pa.us>
 <20251011.090731.1451293026979559494.ishii@postgresql.org>
 <20251011.144218.1729318385118014326.ishii@postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/66A28678-BDC0-4266-9244-74320D578222%40gmail.com>
Precedence: bulk


--Apple-Mail=_3BDFC205-B40A-4D0A-8D5A-4CDC9A76CF7D
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> On Oct 11, 2025, at 13:42, Tatsuo Ishii <ishii@postgresql.org> wrote:
>=20
>>> Also the error is certainly user-facing,
>>> so using elog() was quite inappropriate.  It should be ereport with =
an
>>> errcode of (probably) ERRCODE_FEATURE_NOT_SUPPORTED.  Rolling your
>>> own implementation of get_func_name() wasn't great either.
>>=20
>> I overlooked the elog() call and "own implementation of
>> get_func_name()". Will fix.
>=20
> Attached is a trivial patch to fix that. I am going to push it if
> there's no objection.
>=20
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS K.K.
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp
> <v1-0001-Use-ereport-rather-than-elog-in-WinCheckAndInitia.patch>


I just take a quick look at the patch, a tiny comment is:

```
+		char	   *funcname =3D =
get_func_name(fcinfo->flinfo->fn_oid);
```

This can be a =E2=80=9Cconst char *=E2=80=9D.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/


--Apple-Mail=_3BDFC205-B40A-4D0A-8D5A-4CDC9A76CF7D
Content-Transfer-Encoding: quoted-printable
Content-Type: text/html;
	charset=utf-8

<html><head><meta http-equiv=3D"content-type" content=3D"text/html; =
charset=3Dutf-8"></head><body style=3D"overflow-wrap: break-word; =
-webkit-nbsp-mode: space; line-break: after-white-space;"><br =
id=3D"lineBreakAtBeginningOfMessage"><div><br><blockquote =
type=3D"cite"><div>On Oct 11, 2025, at 13:42, Tatsuo Ishii =
&lt;ishii@postgresql.org&gt; wrote:</div><br =
class=3D"Apple-interchange-newline"><div><div><blockquote =
type=3D"cite"><blockquote type=3D"cite">Also the error is certainly =
user-facing,<br>so using elog() was quite inappropriate. &nbsp;It should =
be ereport with an<br>errcode of (probably) =
ERRCODE_FEATURE_NOT_SUPPORTED. &nbsp;Rolling your<br>own implementation =
of get_func_name() wasn't great either.<br></blockquote><br>I overlooked =
the elog() call and "own implementation of<br>get_func_name()". Will =
fix.<br></blockquote><br>Attached is a trivial patch to fix that. I am =
going to push it if<br>there's no objection.<br><br>Best =
regards,<br>--<br>Tatsuo Ishii<br>SRA OSS K.K.<br>English: =
http://www.sraoss.co.jp/index_en/<br>Japanese:http://www.sraoss.co.jp<br><=
span =
id=3D"cid:8C7D2BC5-F665-497A-9427-3080FE970E60">&lt;v1-0001-Use-ereport-ra=
ther-than-elog-in-WinCheckAndInitia.patch&gt;</span></div></div></blockquo=
te></div><div><br></div><div>I just take a quick look at the patch, a =
tiny comment is:</div><div><br></div><div>```</div><div>+<span =
class=3D"Apple-tab-span" style=3D"white-space:pre">		=
</span>char<span class=3D"Apple-tab-span" style=3D"white-space:pre">	=
</span> &nbsp; *funcname =3D =
get_func_name(fcinfo-&gt;flinfo-&gt;fn_oid);</div><div>```</div><div><br><=
/div><div>This can be a =E2=80=9Cconst char =
*=E2=80=9D.</div><div><br></div>Best regards,<br><div>
<div dir=3D"auto" style=3D"caret-color: rgb(0, 0, 0); color: rgb(0, 0, =
0); letter-spacing: normal; text-align: start; text-indent: 0px; =
text-transform: none; white-space: normal; word-spacing: 0px; =
-webkit-text-stroke-width: 0px; text-decoration: none; overflow-wrap: =
break-word; -webkit-nbsp-mode: space; line-break: =
after-white-space;"><div>--</div><div>Chao Li (Evan)<br>HighGo Software =
Co., Ltd.<br>https://www.highgo.com/</div><div><br></div></div><br =
class=3D"Apple-interchange-newline"><br =
class=3D"Apple-interchange-newline">

</div>
<br></body></html>=

--Apple-Mail=_3BDFC205-B40A-4D0A-8D5A-4CDC9A76CF7D--