Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1seUmi-007ud3-2n for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Aug 2024 07:20:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1seUmg-00F7gL-Qd for pgsql-hackers@arkaria.postgresql.org; Thu, 15 Aug 2024 07:20:34 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1seUmg-00F7g5-Gc for pgsql-hackers@lists.postgresql.org; Thu, 15 Aug 2024 07:20:34 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1seUme-004pIB-2v; Thu, 15 Aug 2024 07:20:33 +0000 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a8384008482so36889066b.2; Thu, 15 Aug 2024 00:20:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723706430; x=1724311230; darn=postgresql.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :subject:cc:to:from:date:sender:message-id:from:to:cc:subject:date :message-id:reply-to; bh=bmgzOzVi83cKCcvZAB/ujTTsagMMOMbDfHxLwYelDfw=; b=YuQXTDKUUWCavx8nC029Wo+nSFb8mNGIxvSORGJqMi1mtn89yjXu1OQC19lUFwef7W tjvPS5GRBGg8caNaCaTAXsyxABI3bXz2lH/q9TOe5Msz/+YhntzgHF0me4ZO1C/qiCbU bscr+l9xgjQ7to/6D2Ilnf5JbcQDLhexk2pBXkxOCa2XIEoP8F/Db7stBEZ7H6d/xJyz aptb1DzYAGZ7m/hi0c6g6FZuWrn/6sUu2YDzO/VJG621gA7VKV+QO5+3yKOktUrsI+8/ aQ0hoK025AN1LnvwSPP5qnBBXHNrfKbj6M84Jgnrg5cnU2uq7mEw0jvS0sqsh5XZLiXM rSHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723706430; x=1724311230; h=user-agent:in-reply-to:content-disposition:mime-version:references :subject:cc:to:from:date:sender:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bmgzOzVi83cKCcvZAB/ujTTsagMMOMbDfHxLwYelDfw=; b=j4RNUDQZrhrVUC8tl2kC7fVe7qGEpeTOMD0SLiYhTeDgi96OXjDANUCKyGJQCBWC55 v16mMcA0OsDjWD7WZpCwpG0IKdAS+3AjEWUks8pBD2hV3GW+qeyfBRjAUkrhhlACUf2m UJAFLfN/pzeT1LO2+mFzueNGMMXeydFyUmOZ/ntND3H33irw0Yq4ENrqTgmwZAZnkAwG DV8yg2hb7VgPsCVI0egwonULAH4wcjGdinMdevzCxyPbA62COoeljwBTukrs6QKFYgFc gDMeWz3Ub8jb7IQYK7rIA6MVnFP6moRohj2J8AnK8XLWyxpRXiedlPyc3gMKTRZY6fnz zyoA== X-Forwarded-Encrypted: i=1; AJvYcCXhWlSzZSJJJj9YCnivvEiztatmNqyjIfekChH6LNjE+J+Q0sgUdUHlpvzH1IpYZWXSBLYFh2XKJ62y+EsYe1HILCcT98TgwptRIY1E4mKKQmAVoYBPpPpR5yeB3oAcOQ44rSA= X-Gm-Message-State: AOJu0Yws+eZzntQeq5JeweUsc08J/N5vWbP8RAyCJlvnTIjPVotL88Nd PgxfoKnB+eJvSGGNllrkEvHXqqT4QBy8aZFU/XPCMVU5dOQ+MUWf X-Google-Smtp-Source: AGHT+IEC0LLi259HT36sOGFHvEfs0wYRbyeBaKeD40aGl2Dbzq9nUxm24gke2ax/2nidU3c5RhinMw== X-Received: by 2002:a17:907:e6d7:b0:a7a:929f:c0cb with SMTP id a640c23a62f3a-a8366d7837dmr357516766b.38.1723706430068; Thu, 15 Aug 2024 00:20:30 -0700 (PDT) Received: from lightning.caipicrew.dd-dns.de ([2001:a61:a05:fe01:9333:ff0e:c35f:d646]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a83838c68e7sm57756866b.8.2024.08.15.00.20.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Aug 2024 00:20:29 -0700 (PDT) Message-ID: <66bdac3d.170a0220.21e804.17df@mx.google.com> X-Google-Original-Message-ID: <20240815072027.GF4146@caipicrew.dd-dns.de;lightning.caipicrew.dd-dns.de> Sender: Michael Banck Received: from mbanck by lightning.caipicrew.dd-dns.de with local (Exim 4.92) (envelope-from ) id 1seUma-00086T-KX; Thu, 15 Aug 2024 09:20:28 +0200 Date: Thu, 15 Aug 2024 09:20:28 +0200 From: Michael Banck To: Jeff Davis Cc: Heikki Linnakangas , PostgreSQL Hackers , Holger Jakobs , Jeff Davis Subject: Re: Improve error message for ICU libraries if pkg-config is absent References: <66b5d05c.050a0220.7c8ce.a951@mx.google.com> <66b5e4e4.170a0220.3cbf42.a1a2@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On Wed, Aug 14, 2024 at 06:05:19PM -0700, Jeff Davis wrote: > That looks good to me. Does anyone have a different opinion? If not, > I'll go ahead and commit (but not backport) this change. What is the rationale not to backpatch this? The error message changes, but we do not translate configure output, so is this a problem/project policy to never change configure output in the back-branches? If the change is too invasive, would something like the initial patch I suggested (i.e., in the absense of pkg-config, add a more targetted error message) be acceptable for the back-branches? Michael