Message-ID: <66df9a53-4fd8-448d-87b3-fd15b2d77ea2@enterprisedb.com>
Date: Sat, 24 Feb 2024 18:10:18 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Functions to return random numbers in a given range
To: Dean Rasheed <dean.a.rasheed@gmail.com>,
 David Zhang <david.zhang@highgo.ca>
Cc: Pavel Stehule <pavel.stehule@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <CAEZATCV89Vxuq93xQdmc0t-0Y2zeeNQTdsjbmV7dyFBPykbV4Q@mail.gmail.com>
 <CAFj8pRCLhfAJvwSOLRJiqY6uib1_T9qzhO+quky3snJ+uHSgjA@mail.gmail.com>
 <bf6787b9-1f3e-4b63-8af6-f44ff43f9653@highgo.ca>
 <CAEZATCWAL9X=6T94=C9hW3RPMVqh9EPHAYTLAL_CebBk2jgwtw@mail.gmail.com>
Content-Language: en-US
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
In-Reply-To: <CAEZATCWAL9X=6T94=C9hW3RPMVqh9EPHAYTLAL_CebBk2jgwtw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/66df9a53-4fd8-448d-87b3-fd15b2d77ea2%40enterprisedb.com>
Precedence: bulk

Hi Dean,

I did a quick review and a little bit of testing on the patch today. I
think it's a good/useful idea, and I think the code is ready to go (the
code is certainly much cleaner than anything I'd written ...).

I do have one minor comments regarding the docs - it refers to "random
functions" in a couple places, which sounds to me as if it was talking
about some functions arbitrarily taken from some list, although it
clearly means "functions generating random numbers". (I realize this
might be just due to me not being native speaker.)


Did you think about adding more functions generating either other types
of data distributions (now we have uniform and normal), or random data
for other data types (I often need random strings, for example)?

Of course, I'm not saying this patch needs to do that. But perhaps it
might affect how we name stuff to make it "extensible".


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company