Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVrLN-0004CJ-Ea for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Sep 2022 09:27:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oVrLL-0006qt-W1 for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Sep 2022 09:27:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVrLL-0006qj-M5 for pgsql-hackers@lists.postgresql.org; Wed, 07 Sep 2022 09:27:35 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVrLJ-00078X-3I for pgsql-hackers@postgresql.org; Wed, 07 Sep 2022 09:27:35 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id BC47D5C00F0; Wed, 7 Sep 2022 05:27:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 07 Sep 2022 05:27:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1662542851; x= 1662629251; bh=0PcaGzd8AW+0A3vXRrVVYNMFbB1j1eCy4eYSapzb0r4=; b=S WQAj/dliMXtlV9JdY3UgVFlu5qtYY4taFxSQXLJY9S8z/JI+yQEzyvsgXuc3WDv4 gPxSufP5HEjrP1311kGGEXiWwe2b+txQf1laKAQmQd6Vp+ByQ3WpuTi5Nq4ARqDU 6XImqgtu+FCHGcTLxkClcv4628yOOOTMee9/UVNCj3HK0/+QLCWuhv7eOONJcbl9 2633087O6fI5j5+jDKS/08wpMva9qa3j9gWrwvXc5xqhspBTvyic/Dcn057Hj1WW ZR3AHqZ1hDzcWZx8nYE1XRKazsZfV6dqwr48IH4fqB7az9kp3E8cHjaujPO8gBgt fWgDi9HKtcdOJRFa4nc+A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedttddgudegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnth gvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpeehleffgeegudejteei hfelteduvdeifffhffdvjedvffegjeekudeludehudeifeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghu thesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 Sep 2022 05:27:30 -0400 (EDT) Message-ID: <66dffd3b-1a13-85b8-203c-4bbcda00d226@enterprisedb.com> Date: Wed, 7 Sep 2022 11:27:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: build remaining Flex files standalone Content-Language: en-US To: Andres Freund , John Naylor , Steve Singer , pavel.stehule@gmail.com Cc: Tom Lane , PostgreSQL Development References: <20220811040748.uygcztrtwrj63mci@awork3.anarazel.de> <20220815181146.gf3qittblwf3tfcs@awork3.anarazel.de> <20220817011431.ea2owxl4abb5zzor@awork3.anarazel.de> <20220902182902.vsjjwnxd3vietvup@awork3.anarazel.de> <20220904181759.px6uosll6zbxcum5@awork3.anarazel.de> From: Peter Eisentraut In-Reply-To: <20220904181759.px6uosll6zbxcum5@awork3.anarazel.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 04.09.22 20:17, Andres Freund wrote: > I think, as a followup improvement, we should move gramparse.h to > src/backend/parser, and stop installing gram.h, gramparse.h. gramparse.h > already had this note: > > * NOTE: this file is only meant to be included in the core parsing files, > * i.e., parser.c, gram.y, and scan.l. > * Definitions that are needed outside the core parser should be in parser.h. > > What do you think? I found in my notes: * maybe gram.h and gramparse.h should not be installed So, yeah. ;-)