Subject: Re: Remove win32ver.rc from version_stamp.pl
To: Tom Lane <tgl@sss.pgh.pa.us>
References: <1ee46ac4-a9b2-4531-bf54-5ec2e374634d@2ndquadrant.com>
 <10989.1583103086@sss.pgh.pa.us>
 <5599e5cb-7d07-c4fc-24f9-273c4b7a2eec@2ndquadrant.com>
 <10432.1583765753@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <67111310-fbdb-132d-05b1-9566a6b59e98@2ndquadrant.com>
Date: Tue, 10 Mar 2020 11:54:58 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <10432.1583765753@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-03-09 15:55, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> On 2020-03-01 23:51, Tom Lane wrote:
>>> In general, while I'm on board with the idea, I wonder whether it
>>> wouldn't be smarter to keep on defining PG_MAJORVERSION as a string,
>>> and just add PG_MAJORVERSION_NUM alongside of it.
> 
>> Agreed.  Here is another patch.
> 
> This version LGTM.  (I can't actually test the Windows aspects
> of this, but I assume you did.)

committed

> I'm wondering a little bit whether it'd be worth back-patching the
> additions of the new #defines.  That would cut about five years off
> the time till they could be relied on by extensions.  However,
> I'm not sure anyone is eager to rely on them, so it may not be
> worth the effort.

I doubt external code really needs these symbols.  You can always use 
PG_VERSION_NUM.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services