Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1faoth-0002Gx-Oa for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Jul 2018 21:01:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1faotf-0006A7-Py for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Jul 2018 21:01:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1faotf-00069w-JQ for pgsql-hackers@lists.postgresql.org; Wed, 04 Jul 2018 21:01:07 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1faotZ-0004fs-VZ for pgsql-hackers@postgresql.org; Wed, 04 Jul 2018 21:01:04 +0000 Received: from pro.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w64L0uww003877; Wed, 4 Jul 2018 17:00:56 -0400 From: Tom Lane To: Andrew Gierth cc: Peter Eisentraut , pgsql-hackers@postgresql.org, Andres Freund Subject: Re: Should contrib modules install .h files? In-reply-to: <874lhho071.fsf@news-spur.riddles.org.uk> References: <87y3euomjh.fsf@news-spur.riddles.org.uk> <87tvpinfr4.fsf@news-spur.riddles.org.uk> <63444.1530537990@sss.pgh.pa.us> <87lgatohzp.fsf@news-spur.riddles.org.uk> <63655.1530540982@sss.pgh.pa.us> <87h8lhoevw.fsf@news-spur.riddles.org.uk> <63819.1530544945@sss.pgh.pa.us> <878t6to8j9.fsf@news-spur.riddles.org.uk> <874lhho071.fsf@news-spur.riddles.org.uk> Comments: In-reply-to Andrew Gierth message dated "Mon, 02 Jul 2018 21:27:42 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <67426.1530738056.1@sss.pgh.pa.us> Date: Wed, 04 Jul 2018 17:00:56 -0400 Message-ID: <67427.1530738056@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Andrew Gierth writes: > This installs to $(includedir_server)/$(MODULEDIR)/$MODULE/file.h > (e.g. include/server/extension/hstore/hstore.h for an actual example), > and errors if HEADERS_xxx is defined for anything that's not a module > listed in MODULES or MODULE_big. I've not studied this patch in any great detail, but the basic plan seems sane. However, don't we also need to teach the MSVC build system about this? regards, tom lane