From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
cc: Michael Paquier <michael@paquier.xyz>,
        Vik Fearing <vik.fearing@2ndquadrant.com>,
        Fabien COELHO <coelho@cri.ensmp.fr>,
        PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Add %x to PROMPT1 and PROMPT2
In-reply-to: <5E008326-2335-4FB2-8513-D9018EC94F02@yesql.se>
References: <09502c40-cfe1-bb29-10f9-4b3fa7b2bbb2@2ndquadrant.com>
 <alpine.DEB.2.21.2001261946530.29788@pseudo>
 <e04078e8-ae4a-b09d-896d-5f2f5a042248@2ndquadrant.com>
 <alpine.DEB.2.21.2001271250190.24374@pseudo>
 <13bc9081-2cf8-bf99-bedb-ce70c82bebc8@2ndquadrant.com>
 <20200203070807.GD2180@paquier.xyz>
 <5E008326-2335-4FB2-8513-D9018EC94F02@yesql.se>
Comments: In-reply-to Daniel Gustafsson <daniel@yesql.se>
	message dated "Mon, 03 Feb 2020 13:40:48 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6748.1580740801.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 03 Feb 2020 09:40:01 -0500
Message-ID: <6749.1580740801@sss.pgh.pa.us>
Precedence: bulk

Daniel Gustafsson <daniel@yesql.se> writes:
> On 3 Feb 2020, at 08:08, Michael Paquier <michael@paquier.xyz> wrote:
>> FWIW, I am not really in favor of changing a default old enough that
>> it could vote (a45195a).

> That by itself doesn't seem a good reason to not change things.

> My concern would be that users who have never ever considered that the p=
rompt
> can be changed, all of sudden wonder why the prompt is showing character=
s it
> normally isn't, thus causing confusion.  That being said, I agree that t=
his is
> a better default long-term.

I've got the same misgivings as Michael.  In a green field this'd likely
be a good idea, but after so many years I'm afraid it will make fewer
people happy than unhappy.

Now on the other hand, we did change the server's default log_line_prefix
not so long ago (7d3235ba4), and the feared storm of complaints was pretty
much undetectable.  So maybe this'd go down the same way.  Worth noting
also is that this shouldn't be able to break any applications, since the
prompt is an interactive-only behavior.

			regards, tom lane