Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hsaaj-0006A0-VS
	for pgsql-hackers@arkaria.postgresql.org; Tue, 30 Jul 2019 22:27:34 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1hsaai-00041j-4f
	for pgsql-hackers@arkaria.postgresql.org; Tue, 30 Jul 2019 22:27:32 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hsaah-0003xe-Qh
	for pgsql-hackers@lists.postgresql.org; Tue, 30 Jul 2019 22:27:31 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1hsaab-0001P2-EF
	for pgsql-hackers@lists.postgresql.org; Tue, 30 Jul 2019 22:27:31 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x6UMRJFm006780;
	Tue, 30 Jul 2019 18:27:19 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Rowley <david.rowley@2ndquadrant.com>
cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
        Yuzuko Hosoya <hosoya.yuzuko@lab.ntt.co.jp>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Runtime pruning problem
In-reply-to: 
 <CAKJS1f82v4fEtH-XkGfUq-QEDErYBvkH8BkmchAT53vUjD+g7Q@mail.gmail.com>
References: <001001d4f44b$2a2cca50$7e865ef0$@lab.ntt.co.jp>
 <CAKJS1f_4b9J7K7DSuZMkyga67OetfyAWz1xzYJd25HSf9-cijQ@mail.gmail.com>
 <b50238ec-e402-6fcb-7f3a-b74418471b29@lab.ntt.co.jp>
 <CAKJS1f98o-6-SWWzcfiJO6JAQFu2DnYWBzFVB0x2+u5ub=ASEA@mail.gmail.com>
 <c4acce90-8265-c91f-065f-e4507ad054bd@lab.ntt.co.jp>
 <2018.1555473241@sss.pgh.pa.us>
 <CAKJS1f9ch8rVy8ZhsV2J7q0zCq4xFuXWxTT90EadpkTsgCvQQw@mail.gmail.com>
 <2923.1555474214@sss.pgh.pa.us>
 <f1ad1911-df47-b555-8df5-825e3a8aa69c@lab.ntt.co.jp>
 <17368.1555608352@sss.pgh.pa.us>
 <CAKJS1f_020O9bX-c1cGcDM2L5DU44hRQ3k_0MXBBqKxAQ=X5bg@mail.gmail.com>
 <CAKJS1f_GZ6LtonDHBJ0pgwtT+OFWmJBap60Fb9iQ++it4aXCFA@mail.gmail.com>
 <CAKJS1f_mw47rnotO4VvpmH42cVKAPn0bkTCzevugGPqeQrW6uQ@mail.gmail.com>
 <CAKJS1f82v4fEtH-XkGfUq-QEDErYBvkH8BkmchAT53vUjD+g7Q@mail.gmail.com>
Comments: In-reply-to David Rowley <david.rowley@2ndquadrant.com>
	message dated "Tue, 23 Jul 2019 20:49:52 +1200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6778.1564525639.1@sss.pgh.pa.us>
Date: Tue, 30 Jul 2019 18:27:19 -0400
Message-ID: <6779.1564525639@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

David Rowley <david.rowley@2ndquadrant.com> writes:
> The part I wouldn't mind another set of eyes on is the ruleutils.c
> changes.

Um, sorry for not getting to this sooner.

What I had in mind was to revert 1cc29fe7c's ruleutils changes
entirely, so that ruleutils deals only in Plans not PlanStates.
Perhaps we've grown some code since then that really needs the
PlanStates, but what is that, and could we do it some other way?
I'm not thrilled with passing both of these around, especially
if the PlanState sometimes isn't there, meaning that no code in
ruleutils could safely assume it's there anyway.

			regards, tom lane