Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s4cND-005knS-RJ for pgsql-hackers@arkaria.postgresql.org; Wed, 08 May 2024 08:10:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1s4cN9-007RjD-Va for pgsql-hackers@arkaria.postgresql.org; Wed, 08 May 2024 08:09:56 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s4cN7-007Rip-Vo for pgsql-hackers@lists.postgresql.org; Wed, 08 May 2024 08:09:56 +0000 Received: from fout6-smtp.messagingengine.com ([103.168.172.149]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1s4cN3-001zzi-W1 for pgsql-hackers@postgresql.org; Wed, 08 May 2024 08:09:53 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfout.nyi.internal (Postfix) with ESMTP id 46DA51380FF7; Wed, 8 May 2024 04:09:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 08 May 2024 04:09:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1715155788; x=1715242188; bh=uRp2i9Lff/IcaMmdeWo448fk6qAVA5NSlh8NaLIxyyw=; b= wK9957cCuHbRs3hiNxlg74vQ1M3yPEUuv6M0XNyYdcuI893qCDcjJuCH+8HBW6Wj f8bgiH7Ff1tWnI8RxaJUvgHnbFeK2hrvSMouvJUxM2UcCb6zBXJbwEUNMptGEEgF CpG1puhYwJcZjMeChI4s9hbajVBTilGgB406ndM1Z6gONq1AIvWBaUp6n6n90Er7 D8Pyv41t3GTZEIgX3M6461yh4TKuT5lM60TZasBxW+grLLEdUoy/LCxAUl7s30Mq kRDSlF5vIe4/mHrsCdk09woz6YrBkjuGCGA2tbd2rN8EkR9SpPTk7FL3zdeJQcL7 CGfI+5i//hbv8ScWjMuutA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1715155788; x= 1715242188; bh=uRp2i9Lff/IcaMmdeWo448fk6qAVA5NSlh8NaLIxyyw=; b=E CD6RWlmTT3/kUw3c3Sk094E8uBkzRlBqL28xO4XtWZEnCeGcBv5XWyISEqXR9MJE f15Zrz6IT4l0HWMR2jvhpk/zU7PaB+EbpmPABQrnA5VAk7SNSHRYjuiucFHsiLyj /ubiCdhwfzX1Slvz3u2rWO7m1JZgHI/mA/CqejyQ9luGLNv2ktOenCs0o1Hk3kTN VMC3u+Jamd0+qQWdh5bVs/PjZ27Oh/6e3mnbVC2RWpa8Il9iDemiMgvES8yviZHQ phHuhoT28x1hip7g7aDWm27ZTktiTtlxGX+ext3b17MLbsRhnb8+TKPAozW9aCaB dOD2Ggz8SxlXJYDUEtXxg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvddvledguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgh eqnecuggftrfgrthhtvghrnhepheeivdfhuefhueeggfefheegjedtveeuhfethfeufedv udfgtdeuhefgfeduhfffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 May 2024 04:09:47 -0400 (EDT) Message-ID: <677ed9ca-8653-4c27-80ca-0ea763f0f21f@eisentraut.org> Date: Wed, 8 May 2024 10:09:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: add --no-sync to pg_upgrade's calls to pg_dump and pg_dumpall To: Nathan Bossart , pgsql-hackers@postgresql.org References: <20240503171348.GA1731524@nathanxps13> Content-Language: en-US From: Peter Eisentraut In-Reply-To: <20240503171348.GA1731524@nathanxps13> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 03.05.24 19:13, Nathan Bossart wrote: > This is likely small potatoes compared to some of the other > pg_upgrade-related improvements I've proposed [0] [1] or plan to propose, > but this is easy enough, and I already wrote the patch, so here it is. > AFAICT there's no reason to bother syncing these dump files to disk. If > someone pulls the plug during pg_upgrade, it's not like you can resume > pg_upgrade from where it left off. Also, I think we skipped syncing before > v10, anyway, as the --no-sync flag was only added in commit 96a7128, which > added the code to sync dump files, too. Looks good to me.