Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1nMWex-0003Jr-Ef
	for pgsql-hackers@arkaria.postgresql.org; Tue, 22 Feb 2022 15:00:59 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1nMWew-0006nl-0c
	for pgsql-hackers@arkaria.postgresql.org; Tue, 22 Feb 2022 15:00:58 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1nMWev-0006nb-O2
	for pgsql-hackers@lists.postgresql.org; Tue, 22 Feb 2022 15:00:57 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1nMWep-0007RJ-KR
	for pgsql-hackers@lists.postgresql.org; Tue, 22 Feb 2022 15:00:56 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 21MF0khI678370;
	Tue, 22 Feb 2022 10:00:46 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
cc: daniel@yesql.se, wliang@stu.xidian.edu.cn,
        pgsql-hackers@lists.postgresql.org
Subject: Re: Patch a potential memory leak in describeOneTableDetails()
In-reply-to: <20220222.151401.1451845726756615483.horikyota.ntt@gmail.com>
References: <38da8aa3.14ec.17f0be3d3ad.Coremail.wliang@stu.xidian.edu.cn>
 <20220221.173007.873975756119341113.horikyota.ntt@gmail.com>
 <F4F3D3F5-16A9-49F2-BB33-D8DAC6061742@yesql.se>
 <20220222.151401.1451845726756615483.horikyota.ntt@gmail.com>
Comments: In-reply-to Kyotaro Horiguchi <horikyota.ntt@gmail.com>
	message dated "Tue, 22 Feb 2022 15:14:01 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <678368.1645542046.1@sss.pgh.pa.us>
Date: Tue, 22 Feb 2022 10:00:46 -0500
Message-ID: <678369.1645542046@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/678369.1645542046%40sss.pgh.pa.us>
Precedence: bulk

Kyotaro Horiguchi <horikyota.ntt@gmail.com> writes:
> Anyway, don't we use the -ftabstop option flag to silence compiler?
> The warning is contradicting our convention. The attached adds that
> flag.

No, we use pgindent to not have such inconsistent indentation.

			regards, tom lane