Message-ID: <6790e47f-aa12-e28b-e123-3fbe46f78513@dunslane.net>
Date: Tue, 19 Apr 2022 19:24:58 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: Postgres perl module namespace
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Noah Misch <noah@leadboat.com>,
 Andres Freund <andres@anarazel.de>, Erik Rijkers <er@xs4all.nl>,
 Robert Haas <robertmhaas@gmail.com>, Alvaro Herrera
 <alvherre@alvh.no-ip.org>, Mark Dilger <mark.dilger@enterprisedb.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <072a3088-7988-1c49-4d30-df47cf8e6415@dunslane.net>
 <YXZm2CYR5Z3H9IWL@paquier.xyz>
 <20220418141530.nfxtkohefvwnzncl@alap3.anarazel.de>
 <20220418155224.GA1149931@rfd.leadboat.com>
 <d74da58b-cfee-4fea-a31a-439921c0feb0@dunslane.net>
 <2361941.1650303832@sss.pgh.pa.us>
 <02188900-ba1e-8c6c-c7dd-98294f39c23f@dunslane.net>
 <2364418.1650305263@sss.pgh.pa.us>
 <f0d10209-7921-365a-aa7d-066e8cb8062e@dunslane.net>
 <03909eb8-21ce-ca68-fea0-cd338e35ad59@dunslane.net>
 <Yl86JyFPzbZQXmYa@paquier.xyz>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: <Yl86JyFPzbZQXmYa@paquier.xyz>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/6790e47f-aa12-e28b-e123-3fbe46f78513%40dunslane.net>
Precedence: bulk


On 2022-04-19 Tu 18:39, Michael Paquier wrote:
> On Tue, Apr 19, 2022 at 04:06:28PM -0400, Andrew Dunstan wrote:
>> Here's a version with a fixed third patch that corrects a file misnaming
>> and fixes the export issue referred to above. Passes my testing so far.
> Wow.  That's really cool.  You are combining the best of both worlds
> here to ease backpatching, as far as I understand what you wrote.


Thanks.


>
> +*generate_ascii_string = *TestLib::generate_ascii_string;
> +*slurp_dir = *TestLib::slurp_dir;
> +*slurp_file = *TestLib::slurp_file;
>
> I am not sure if it is possible and my perl-fu is limited in this
> area, but could a failure be enforced when loading this path if a new
> routine added in TestLib.pm is forgotten in this list?


Not very easily that I'm aware of, but maybe some superior perl wizard
will know better.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com