Feedback-ID: i0c21471d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-144-ge5821d614e-fm-20240125.002-ge5821d61
MIME-Version: 1.0
Message-Id: <6793c99e-9bb4-4395-8e00-21d7074445c9@app.fastmail.com>
In-Reply-To: 
 <TY3PR01MB9889FD26E1DE89FC8D51973EF5432@TY3PR01MB9889.jpnprd01.prod.outlook.com>
References: <5ac50071-f2ed-4ace-a8fd-b892cffd33eb@www.fastmail.com>
 <4710d895-689a-4ae6-b8e3-344286dbf970@app.fastmail.com>
 <da078f11-d2de-420e-9611-f3b7d4dadd9a@eisentraut.org>
 <ZUrEclC-uZV-rGd2@paquier.xyz>
 <96e3b739-d63d-4d35-90a3-7869465b7167@eisentraut.org>
 <ZU1nR5KMZtSTEQDf@paquier.xyz>
 <e02a2c17-22e5-4ba6-b788-de696ab74f1e@app.fastmail.com>
 <CALDaNm098Jkbh+ye6zMj9Ro9j1bBe6FfPV80BFbs1=pUuTJ07g@mail.gmail.com>
 <2736443c-58e3-42df-8cc4-8c66106e3da5@app.fastmail.com>
 <CAA4eK1KtGC-v_CYd8yaCwisrQvoZN=+As90p9hBM29DAxA+Pmg@mail.gmail.com>
 <CANhcyEUdYCR9oSt4HsZRqYZZVXsb4x-HoPGqDSxSeA2SYz-YGg@mail.gmail.com>
 <CAA4eK1KMQNMhSPmsRdrCQpuc=Tsc08h6=XkLNZ5F35Q2REom6g@mail.gmail.com>
 <CANhcyEXjOcnOJKdOfK8Z1+bbymuZzwSjrppbt4FKHbrDD_t7Mg@mail.gmail.com>
 <CANhcyEUCt-g4JLQU3Q3ofFk_Vt-Tqh3ZdXoLcpT8fjz9LY_-ww@mail.gmail.com>
 <bcd3db13-f56e-47e3-8fa7-7f0c6243c8a6@app.fastmail.com>
 <CAA4eK1JRgnhv_ySzuFjN7UaX9qxz5Hqcwew7Fk=+AbJbu0Kd9w@mail.gmail.com>
 <TY3PR01MB98895BA6C1D72CB8582CACC4F5682@TY3PR01MB9889.jpnprd01.prod.outlook.com>
 <aabc91d2-505b-4412-af08-7dae2df1d437@app.fastmail.com>
 <TY3PR01MB9889C362FF76102C88FA1C29F56F2@TY3PR01MB9889.jpnprd01.prod.outlook.com>
 <TY3PR01MB9889C5D55206DDD978627D07F5752@TY3PR01MB9889.jpnprd01.prod.outlook.com>
 <CANhcyEXhpfWgc0-FdHmUG6WGD=2cxYqBePr1yxJ8VSZ0gV3XKA@mail.gmail.com>
 <c402b130-0226-4a2c-bb92-9e83bd6af006@app.fastmail.com>
 <b315c7da-7ab1-4014-a2a9-8ab6ae26017c@app.fastmail.com>
 <TY3PR01MB98895A551923953B3DA3C7C8F5792@TY3PR01MB9889.jpnprd01.prod.outlook.com>
 <d0b1534e-9f63-4966-8fb7-deedb0a626d0@app.fastmail.com>
 <1cd45c1e-8ed1-42fc-9357-f1c43e0d6ac8@app.fastmail.com>
 <OS3PR01MB98828B15DD9502C91E0C50D7F57D2@OS3PR01MB9882.jpnprd01.prod.outlook.com>
 <80ce3f65-7ca3-471e-b1a4-24ac529ff4ea@app.fastmail.com>
 <TY3PR01MB9889FD26E1DE89FC8D51973EF5432@TY3PR01MB9889.jpnprd01.prod.outlook.com>
Date: Thu, 01 Feb 2024 00:05:23 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>,
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Cc: "vignesh C" <vignesh21@gmail.com>,
 "Michael Paquier" <michael@paquier.xyz>,
 "Peter Eisentraut" <peter@eisentraut.org>,
 "Andres Freund" <andres@anarazel.de>,
 "Ashutosh Bapat" <ashutosh.bapat.oss@gmail.com>,
 "Amit Kapila" <amit.kapila16@gmail.com>,
 "Shlok Kyal" <shlok.kyal.oss@gmail.com>
Subject: Re: speed up a logical replica setup
Content-Type: multipart/alternative;
 boundary=767cf882365c41509da5a18b079d3a7b
Archived-At: <https://www.postgresql.org/message-id/6793c99e-9bb4-4395-8e00-21d7074445c9%40app.fastmail.com>
Precedence: bulk

--767cf882365c41509da5a18b079d3a7b
Content-Type: text/plain

On Wed, Jan 31, 2024, at 11:09 PM, Hayato Kuroda (Fujitsu) wrote:
> >
> Why? Are you suggesting that the dry run mode covers just the verification
> part? If so, it is not a dry run mode. I would expect it to run until the end
> (or until it accomplish its goal) but *does not* modify data. For pg_resetwal,
> the modification is one of the last steps and the other ones (KillFoo
> functions) that are skipped modify data. It ends the dry run mode when it
> accomplish its goal (obtain the new control data values). If we stop earlier,
> some of the additional steps won't be covered by the dry run mode and a failure
> can happen but could be detected if you run a few more steps.
> >
> 
> Yes, it was my expectation. I'm still not sure which operations can detect by the
> dry_run, but we can keep it for now.

The main goal is to have information for troubleshooting.

> 
> Good point. I included a check for pg_create_subscription role and CREATE
> privilege on the specified database.
> >
> 
> Not sure, but can we do the replication origin functions by these privilege?
> According to the doc[1], these ones seem not to be related.

Hmm. No. :( Better add this check too.


--
Euler Taveira
EDB   https://www.enterprisedb.com/

--767cf882365c41509da5a18b079d3a7b
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Wed, Jan 31,=
 2024, at 11:09 PM, Hayato Kuroda (Fujitsu) wrote:<br></div><blockquote =
type=3D"cite" id=3D"qt" style=3D""><div>&gt;<br></div><div>Why? Are you =
suggesting that the dry run mode covers just the verification<br></div><=
div>part? If so, it is not a dry run mode. I would expect it to run unti=
l the end<br></div><div>(or until it accomplish its goal) but *does not*=
 modify data. For pg_resetwal,<br></div><div>the modification is one of =
the last steps and the other ones (KillFoo<br></div><div>functions) that=
 are skipped modify data. It ends the dry run mode when it<br></div><div=
>accomplish its goal (obtain the new control data values). If we stop ea=
rlier,<br></div><div>some of the additional steps won't be covered by th=
e dry run mode and a failure<br></div><div>can happen but could be detec=
ted if you run a few more steps.<br></div><div>&gt;<br></div><div><br></=
div><div>Yes, it was my expectation. I'm still not sure which operations=
 can detect by the<br></div><div>dry_run, but we can keep it for now.<br=
></div></blockquote><div><br></div><div>The main goal is to have informa=
tion for troubleshooting.</div><div><br></div><blockquote type=3D"cite" =
id=3D"qt" style=3D""><div><br></div><div>Good point. I included a check =
for pg_create_subscription role and CREATE<br></div><div>privilege on th=
e specified database.<br></div><div>&gt;<br></div><div><br></div><div>No=
t sure, but can we do the replication origin functions by these privileg=
e?<br></div><div>According to the doc[1], these ones seem not to be rela=
ted.<br></div></blockquote><div><br></div><div>Hmm. No. :( Better add th=
is check too.</div><div><br></div><div><br></div><div id=3D"sig112409080=
"><div class=3D"signature">--<br></div><div class=3D"signature">Euler Ta=
veira<br></div><div class=3D"signature">EDB&nbsp;&nbsp; <a href=3D"https=
://www.enterprisedb.com/">https://www.enterprisedb.com/</a><br></div></d=
iv><div><br></div></body></html>
--767cf882365c41509da5a18b079d3a7b--