From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@lists.postgresql.org,
        Thomas Munro <thomas.munro@enterprisedb.com>,
        Andrew Gierth <andrew@tao11.riddles.org.uk>,
        Alexander Kuzmenkov <a.kuzmenkov@postgrespro.ru>
Subject: Re: Performance improvements for src/port/snprintf.c
In-reply-to: <20181003183552.xaams6fau3i7oybj@alap3.anarazel.de>
References: <20181003161454.ozeioucsimjg5g6m@alap3.anarazel.de>
 <27041.1538583733@sss.pgh.pa.us>
 <20181003163717.oycshpp2hnctvtfj@alap3.anarazel.de>
 <28321.1538585692@sss.pgh.pa.us>
 <20181003170043.thdyezozi343dkuc@alap3.anarazel.de>
 <2132.1538587869@sss.pgh.pa.us>
 <20181003173639.tncawup2nnkp7vbv@alap3.anarazel.de>
 <2435.1538588403@sss.pgh.pa.us>
 <20181003174513.wxjxfj7eepytnlqa@alap3.anarazel.de>
 <3316.1538589695@sss.pgh.pa.us>
 <20181003183552.xaams6fau3i7oybj@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 03 Oct 2018 11:35:52 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6796.1538592539.1@sss.pgh.pa.us>
Date: Wed, 03 Oct 2018 14:48:59 -0400
Message-ID: <6797.1538592539@sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2018-10-03 14:01:35 -0400, Tom Lane wrote:
>> BTW, so far as I can tell on F28, strfromd isn't exposed without
>> "-D__STDC_WANT_IEC_60559_BFP_EXT__", which seems fairly scary;
>> what else does that affect?

> So I don't think anything's needed to enable that in pg, given that we
> define _GNU_SOURCE

Ah, OK.  I thought my test case had _GNU_SOURCE defined already,
but it didn't.  You might want to do something like what I stuck
in for strchrnul, though:

/*
 * glibc's <string.h> declares strchrnul only if _GNU_SOURCE is defined.
 * While we typically use that on glibc platforms, configure will set
 * HAVE_STRCHRNUL whether it's used or not.  Fill in the missing declaration
 * so that this file will compile cleanly with or without _GNU_SOURCE.
 */
#ifndef _GNU_SOURCE
extern char *strchrnul(const char *s, int c);
#endif


			regards, tom lane