Subject: Re: FmgrInfo allocation patterns (and PL handling as staged
 programming)
To: Tom Lane <tgl@sss.pgh.pa.us>
References: <67F2B767.9040507@acm.org> <2965818.1743960827@sss.pgh.pa.us>
 <67F2D87F.1000709@acm.org> <2978258.1743968866@sss.pgh.pa.us>
 <67F30DDA.4000509@acm.org> <3112950.1743984111@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
 Peter Eisentraut <peter@eisentraut.org>
From: Chapman Flack <jcflack@acm.org>
Message-ID: <67F31F20.6090706@acm.org>
Date: Sun, 6 Apr 2025 20:41:04 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: <3112950.1743984111@sss.pgh.pa.us>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/67F31F20.6090706%40acm.org>
Precedence: bulk

On 04/06/25 20:01, Tom Lane wrote:
> Looking more closely at ProcedureCreate(), it makes a dependency
> if a transform *exists* for the argument or result type, whether
> a TRANSFORM clause is present or not.  Surely this is completely
> bogus?  We should be depending on the OIDs mentioned in protrftypes,

I think that's it. I tested by creating a function like

create function foo() returns text transform for type circle

that is, with the transform type not appearing as an argument or
return type.

As far as I know, that's still a cromulent usage, as I could be saying
I want the function to apply that transform to circles it uses or retrieves
in queries it makes.

But if the dependency is being created based on argument/return types
and not on protrftypes, that will slip right through the cracks.

Regards,
-Chap