Message-ID: <67f847bb-a1c2-f444-b2e0-333a97f1953a@amazon.com>
Date: Mon, 22 Aug 2022 07:51:39 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.1.2
Subject: Re: shared-memory based stats collector - v70
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
CC: <andres@anarazel.de>, <stark@mit.edu>,
	<pgsql-hackers@lists.postgresql.org>
References: <20220809165319.jdzd225xohqf6o57@awork3.anarazel.de>
 <20220810.113910.92411510444435201.horikyota.ntt@gmail.com>
 <3d853c6f-445f-782e-eab0-525729952d4c@amazon.com>
 <20220822.113214.157880042751504547.horikyota.ntt@gmail.com>
Content-Language: en-US
From: "Drouvot, Bertrand" <bdrouvot@amazon.com>
In-Reply-To: <20220822.113214.157880042751504547.horikyota.ntt@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/67f847bb-a1c2-f444-b2e0-333a97f1953a%40amazon.com>
Precedence: bulk

Hi,

On 8/22/22 4:32 AM, Kyotaro Horiguchi wrote:
> At Wed, 10 Aug 2022 14:02:34 +0200, "Drouvot, Bertrand" <bdrouvot@amazon.com> wrote in
>> what about?
>>
>> +               /*
>> +                * Acquire the LWLock directly instead of using
>> pg_stat_lock_entry_shared()
>> +                * which requires a reference.
>> +                */
>>
>>
>> I think that's more consistent with other comments mentioning LWLock
>> acquisition.
> Sure. Thaks!. I did that in the attached.

Thank you!

The patch looks good to me.

Regards,

Bertrand