Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLh3w-0007Tw-16 for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Sep 2020 06:18:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kLh3u-00059x-Ue for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Sep 2020 06:18:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLh3u-00059o-Ni for pgsql-hackers@lists.postgresql.org; Fri, 25 Sep 2020 06:18:30 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLh3o-0004Sc-Dp for pgsql-hackers@postgresql.org; Fri, 25 Sep 2020 06:18:30 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTP id 1CB5E622EB; Fri, 25 Sep 2020 15:18:20 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.102.3 at oss.nttdata.com MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_4d0ea81567f697caeb180a41e5b2bb00" Date: Fri, 25 Sep 2020 15:18:20 +0900 From: btnakamichin To: Fujii Masao Cc: pgsql-hackers@postgresql.org Subject: Re: Feature improvement of tab completion for DEALLOCATE In-Reply-To: <997a84af-c2e2-abe4-aca2-abdfb7383346@oss.nttdata.com> References: <997a84af-c2e2-abe4-aca2-abdfb7383346@oss.nttdata.com> Message-ID: <680a8129485eb754f31ad0ccc1f7151f@oss.nttdata.com> X-Sender: btnakamichin@oss.nttdata.com User-Agent: Roundcube Webmail/1.1.9 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --=_4d0ea81567f697caeb180a41e5b2bb00 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8; format=flowed 2020-09-25 14:30 に Fujii Masao さんは書きました: > On 2020/09/25 13:45, btnakamichin wrote: >> Hello! >> >> I’d like to improve the deallocate tab completion. >> >> The deallocate tab completion can’t complement “ALL”. Therefore, this >> patch fixes the problem. > > Thanks for the patch! It looks basically good, but I think it's better > to add newline just before UNION to avoid long line, as follows. > > - > COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements); > + > COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements > + " UNION SELECT > 'ALL'"); > > Regards, Thank you, I appreciate your comment. I have attached pattch　with newline. Regards, NaokiNskamichi --=_4d0ea81567f697caeb180a41e5b2bb00 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=fix_tab_complete_deallocate_v2.patch Content-Disposition: attachment; filename=fix_tab_complete_deallocate_v2.patch; size=557 ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcHNxbC90YWItY29tcGxldGUuYyBiL3NyYy9iaW4vcHNxbC90 YWItY29tcGxldGUuYwppbmRleCBkODc3Y2M4NmYwLi43NWY4MWQ2NmRjIDEwMDY0NAotLS0gYS9z cmMvYmluL3BzcWwvdGFiLWNvbXBsZXRlLmMKKysrIGIvc3JjL2Jpbi9wc3FsL3RhYi1jb21wbGV0 ZS5jCkBAIC0yOTExLDcgKzI5MTEsOCBAQCBwc3FsX2NvbXBsZXRpb24oY29uc3QgY2hhciAqdGV4 dCwgaW50IHN0YXJ0LCBpbnQgZW5kKQogCiAvKiBERUFMTE9DQVRFICovCiAJZWxzZSBpZiAoTWF0 Y2hlcygiREVBTExPQ0FURSIpKQotCQlDT01QTEVURV9XSVRIX1FVRVJZKFF1ZXJ5X2Zvcl9saXN0 X29mX3ByZXBhcmVkX3N0YXRlbWVudHMgIiBVTklPTiBTRUxFQ1QgJ0FMTCciKTsKKwkJQ09NUExF VEVfV0lUSF9RVUVSWShRdWVyeV9mb3JfbGlzdF9vZl9wcmVwYXJlZF9zdGF0ZW1lbnRzIAorCQkg ICAgICAgICAgICAgICAgICAgICIgVU5JT04gU0VMRUNUICdBTEwnIik7CiAKIC8qIERFQ0xBUkUg Ki8KIAllbHNlIGlmIChNYXRjaGVzKCJERUNMQVJFIiwgTWF0Y2hBbnkpKQo= --=_4d0ea81567f697caeb180a41e5b2bb00--