Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAxbz-0002q5-7O for pgsql-hackers@arkaria.postgresql.org; Fri, 21 Jan 2022 17:22:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nAxbx-0002EL-Ub for pgsql-hackers@arkaria.postgresql.org; Fri, 21 Jan 2022 17:22:05 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAxbx-0002EB-1i for pgsql-hackers@lists.postgresql.org; Fri, 21 Jan 2022 17:22:05 +0000 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nAxbt-0002I6-Ff for pgsql-hackers@postgresql.org; Fri, 21 Jan 2022 17:22:03 +0000 Received: by mail-ed1-x52f.google.com with SMTP id c24so41712883edy.4 for ; Fri, 21 Jan 2022 09:22:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to; bh=1agAxjSdmMByyZY/ZqiuyCuysUZ5G2z0rw0z/btDAlA=; b=UYd3NY6/4XjbNmdnjG0E5nqrUdgwltxnA2NYLffagZRNSKCqbOj3Qoc3UEH2q3702J T2eXpfrk0lUHcIYEI9+P49EcsunNkS1B8/rVHuB+N9FOL/KcNS+H+PpMDqxUhAbRlmsy q+r81YhyKQpivlVqz5D2K8+WdZOotnEctNo66A4hw6Wguh06hxiHFArDMSCcpJH0I7Dc jy2yCqHTN4zoE1L5QT+qZnMdJIxhKwlB/VA0vJZkUN6wZF0mjWtTVVziiqrjPz0ZxawH KJywvE0WtvGholmYVb5HCv8/9JqhGj+1+cya9S4PBTSR4kJgT4+fFKFLMl2iLKCyjxcj Hr0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to; bh=1agAxjSdmMByyZY/ZqiuyCuysUZ5G2z0rw0z/btDAlA=; b=e5/e6JZT1RY2RrFq9O+pKtcx/Jb1ZakbZMsZbnj8p91c9G3EYmSsUv1Bft8gDxv3RS 3/VisjPYtvginwF+Tt7NIxlVWIbG9QQy4qiMR0iuC30zicNIZqzRIGS9+7fbLO/lDHj4 SjMs+dSy+5TPkIEcUF10LBL9iTSPyhClybnRr+vpYievtaca+Jbi3s6SlX02YR5vws96 9UmJSr4fy2eCXXZKjs9ILtF05kyXju84iQUm+QF1Y42xQFy97dLOklr2IvyPRGGwP5TA C0EEM6s3jhYopC5U5ozgSoAGiCtxdXJmxa9ccxL2SNRofdmJo848/QR6jd44zVxxjKKM FAqw== X-Gm-Message-State: AOAM533Zswbvu4KSIM6ju9QpCxZGuSmwTOlg1PaLQkHdaOjPT6Vtd7Ct 8OPzGofWlNqlzQuuObRUFiW3xKKtMSYtmeUKjRZWlCE6In8ylWmXHxfM93/gdyYvuQj5YNzyzk9 T/1eRIpbQ98v8GpZJDXqlbNLOJ64rGm2wDfyO1txc74SA0TK/H/cgiAKRFWMkQQ+qCPlCDS4gm4 o3Bu2yNg96PeXmHj6bx4QNbxpsyMdfxdyHZ0Ul X-Google-Smtp-Source: ABdhPJyouRE8ddGBk9SA/Wr5pxxkfJ9pkfLxWiNQPGiCr49tSRWfQ4H7dzRIo6/jKc5BZbNuHE39ng== X-Received: by 2002:a05:6402:84e:: with SMTP id b14mr5098688edz.200.1642785719940; Fri, 21 Jan 2022 09:21:59 -0800 (PST) Received: from [10.137.0.18] (ip-86-49-251-241.net.upcbroadband.cz. [86.49.251.241]) by smtp.gmail.com with ESMTPSA id h8sm2842576edk.14.2022.01.21.09.21.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jan 2022 09:21:59 -0800 (PST) Content-Type: multipart/mixed; boundary="------------OuCC0Acbd01hY41yA0TGsDOh" Message-ID: <681e76ad-3a7b-ea3c-b6b0-55946239c49b@enterprisedb.com> Date: Fri, 21 Jan 2022 18:21:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: document the need to analyze partitioned tables Content-Language: en-US To: Justin Pryzby , =?UTF-8?Q?=c3=81lvaro_Herrera?= Cc: yuzuko , pgsql-hackers@postgresql.org References: <20210913035409.GA10647@telsasoft.com> <20211008125822.GJ27491@telsasoft.com> From: Tomas Vondra In-Reply-To: <20211008125822.GJ27491@telsasoft.com> X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------OuCC0Acbd01hY41yA0TGsDOh Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 10/8/21 14:58, Justin Pryzby wrote: > Cleaned up and attached as a .patch. > > The patch implementing autoanalyze on partitioned tables should > revert relevant portions of this patch. I went through this patch and I'd like to propose a couple changes, per the 0002 patch: 1) I've reworded the changes in maintenance.sgml a bit. It sounded a bit strange before, but I'm not a native speaker so maybe it's worse ... 2) Remove unnecessary whitespace changes in perform.sgml. 3) Simplify the analyze.sgml changes a bit - it was trying to cram too much stuff into a single paragraph, so I split that. Does that seem OK, or did omit something important? FWIW I think it's really confusing we have inheritance and partitioning, and partitions and child tables. And sometimes we use partitioning in the generic sense (i.e. including the inheritance approach), and sometimes only the declarative variant. Same for partitions vs child tables. I can't even imagine how confusing this has to be for people just learning this stuff. They must be in permanent WTF?! state ... regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company --------------OuCC0Acbd01hY41yA0TGsDOh Content-Type: text/x-patch; charset=UTF-8; name="v2-0001-documentation-deficiencies-for-ANALYZE-of-partiti.patch" Content-Disposition: attachment; filename*0="v2-0001-documentation-deficiencies-for-ANALYZE-of-partiti.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBjNTEwNWYyZjA2N2RmZjU1MzA0NTc5MmQ0YTE3MWZjODM1ZmUyMTA5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKdXN0aW4gUHJ5emJ5IDxwcnl6YnlqQHRlbHNhc29m dC5jb20+CkRhdGU6IFRodSwgMjIgSnVsIDIwMjEgMTY6MDY6MTggLTA1MDAKU3ViamVjdDog W1BBVENIIHYyIDEvMl0gZG9jdW1lbnRhdGlvbiBkZWZpY2llbmNpZXMgZm9yIEFOQUxZWkUg b2YgcGFydGl0aW9uZWQKIHRhYmxlcwoKVGhpcyBpcyBwYXJ0aWFsbHkgZXh0cmFjdGVkIGZy b20gMWI1NjE3ZWI4NDRjZDI0NzBhMzM0YzFkMmVlYzY2Y2Y5YjM5YzQxYSwKd2hpY2ggd2Fz IHJldmVydGVkLgotLS0KIGRvYy9zcmMvc2dtbC9tYWludGVuYW5jZS5zZ21sIHwgMjcgKysr KysrKysrKysrKysrKysrKysrKysrKysKIGRvYy9zcmMvc2dtbC9wZXJmb3JtLnNnbWwgICAg IHwgIDIgKysKIGRvYy9zcmMvc2dtbC9yZWYvYW5hbHl6ZS5zZ21sIHwgMzYgKysrKysrKysr KysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0KIDMgZmlsZXMgY2hhbmdlZCwgNTIgaW5zZXJ0 aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL21h aW50ZW5hbmNlLnNnbWwgYi9kb2Mvc3JjL3NnbWwvbWFpbnRlbmFuY2Uuc2dtbAppbmRleCAz NmY5NzViMWU1Yi4uYjdjODA2Y2M5MDYgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9tYWlu dGVuYW5jZS5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9tYWludGVuYW5jZS5zZ21sCkBAIC0y OTAsNiArMjkwLDE0IEBACiAgICAgdG8gbWVhbmluZ2Z1bCBzdGF0aXN0aWNhbCBjaGFuZ2Vz LgogICAgPC9wYXJhPgogCisgICA8cGFyYT4KKyAgICBUdXBsZXMgY2hhbmdlZCBpbiBwYXJ0 aXRpb25zIGFuZCBpbmhlcml0YW5jZSBjaGlsZHJlbiBkbyBub3QgY291bnQgdG93YXJkcwor ICAgIGFuYWx5emUgb24gdGhlIHBhcmVudCB0YWJsZS4gIElmIHRoZSBwYXJlbnQgdGFibGUg aXMgZW1wdHkgb3IgcmFyZWx5CisgICAgY2hhbmdlZCwgaXQgbWF5IG5ldmVyIGJlIHByb2Nl c3NlZCBieSBhdXRvdmFjdXVtLiAgSXQgaXMgbmVjZXNzYXJ5IHRvCisgICAgcGVyaW9kaWNh bGx5IG1hbnVhbCBydW4gPGNvbW1hbmQ+QU5BTFlaRTwvY29tbWFuZD4gb24gdGhlIHBhcmVu dCB0YWJsZSB0bworICAgIGtlZXAgdGhlIHN0YXRpc3RpY3Mgb2YgaXRzIHRhYmxlIGhpZXJh cmNoeSB1cCB0byBkYXRlLgorICAgPC9wYXJhPgorCiAgICA8cGFyYT4KICAgICBBcyB3aXRo IHZhY3V1bWluZyBmb3Igc3BhY2UgcmVjb3ZlcnksIGZyZXF1ZW50IHVwZGF0ZXMgb2Ygc3Rh dGlzdGljcwogICAgIGFyZSBtb3JlIHVzZWZ1bCBmb3IgaGVhdmlseS11cGRhdGVkIHRhYmxl cyB0aGFuIGZvciBzZWxkb20tdXBkYXRlZApAQCAtMzQ3LDYgKzM1NSwxOCBAQAogICAgICA8 Y29tbWFuZD5BTkFMWVpFPC9jb21tYW5kPiBjb21tYW5kcyBvbiB0aG9zZSB0YWJsZXMgb24g YSBzdWl0YWJsZSBzY2hlZHVsZS4KICAgICA8L3BhcmE+CiAgICA8L3RpcD4KKworICAgPHRp cD4KKyAgICA8cGFyYT4KKyAgICAgVGhlIGF1dG92YWN1dW0gZGFlbW9uIGRvZXMgbm90IGlz c3VlIDxjb21tYW5kPkFOQUxZWkU8L2NvbW1hbmQ+IGNvbW1hbmRzIGZvcgorICAgICBwYXJ0 aXRpb25lZCB0YWJsZXMuICBJbmhlcml0YW5jZSBwYXJlbnRzIHdpbGwgb25seSBiZSBhbmFs eXplZCBpZiB0aGUKKyAgICAgcGFyZW50IGl0c2VsZiBpcyBjaGFuZ2VkIC0gY2hhbmdlcyB0 byBjaGlsZCB0YWJsZXMgZG8gbm90IHRyaWdnZXIKKyAgICAgYXV0b2FuYWx5emUgb24gdGhl IHBhcmVudCB0YWJsZS4gIEl0IGlzIG5lY2Vzc2FyeSB0byBwZXJpb2RpY2FsbHkgcnVuIGEK KyAgICAgbWFudWFsIDxjb21tYW5kPkFOQUxZWkU8L2NvbW1hbmQ+IHRvIGtlZXAgdGhlIHN0 YXRpc3RpY3Mgb2YgdGhlIHRhYmxlCisgICAgIGhpZXJhcmNoeSB1cCB0byBkYXRlLgorICAg IDwvcGFyYT4KKyAgIDwvdGlwPgorCiAgIDwvc2VjdDI+CiAKICAgPHNlY3QyIGlkPSJ2YWN1 dW0tZm9yLXZpc2liaWxpdHktbWFwIj4KQEAgLTgxOSw2ICs4MzksMTMgQEAgYW5hbHl6ZSB0 aHJlc2hvbGQgPSBhbmFseXplIGJhc2UgdGhyZXNob2xkICsgYW5hbHl6ZSBzY2FsZSBmYWN0 b3IgKiBudW1iZXIgb2YgdHUKICAgICBzaW5jZSB0aGUgbGFzdCA8Y29tbWFuZD5BTkFMWVpF PC9jb21tYW5kPi4KICAgIDwvcGFyYT4KIAorICAgPHBhcmE+CisgICAgUGFydGl0aW9uZWQg dGFibGVzIGFyZSBub3QgcHJvY2Vzc2VkIGJ5IGF1dG92YWN1dW0uICBTdGF0aXN0aWNzCisg ICAgc2hvdWxkIGJlIGNvbGxlY3RlZCBieSBydW5uaW5nIGEgbWFudWFsIDxjb21tYW5kPkFO QUxZWkU8L2NvbW1hbmQ+IHdoZW4gaXQgaXMKKyAgICBmaXJzdCBwb3B1bGF0ZWQsIGFuZCB1 cGRhdGVkIHdoZW5ldmVyIHRoZSBkaXN0cmlidXRpb24gb2YgZGF0YSBpbiBpdHMKKyAgICBw YXJ0aXRpb25zIGNoYW5nZXMgc2lnbmlmaWNhbnRseS4KKyAgIDwvcGFyYT4KKwogICAgPHBh cmE+CiAgICAgVGVtcG9yYXJ5IHRhYmxlcyBjYW5ub3QgYmUgYWNjZXNzZWQgYnkgYXV0b3Zh Y3V1bS4gIFRoZXJlZm9yZSwKICAgICBhcHByb3ByaWF0ZSB2YWN1dW0gYW5kIGFuYWx5emUg b3BlcmF0aW9ucyBzaG91bGQgYmUgcGVyZm9ybWVkIHZpYQpkaWZmIC0tZ2l0IGEvZG9jL3Ny Yy9zZ21sL3BlcmZvcm0uc2dtbCBiL2RvYy9zcmMvc2dtbC9wZXJmb3JtLnNnbWwKaW5kZXgg ODlmZjU4MzM4ZTUuLmI4NDg1M2ZkNmZmIDEwMDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwvcGVy Zm9ybS5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9wZXJmb3JtLnNnbWwKQEAgLTE3NjUsOSAr MTc2NSwxMSBAQCBTRUxFQ1QgKiBGUk9NIHgsIHksIGEsIGIsIGMgV0hFUkUgc29tZXRoaW5n IEFORCBzb21ldGhpbmdlbHNlOwogICAgPHRpdGxlPlJ1biA8Y29tbWFuZD5BTkFMWVpFPC9j b21tYW5kPiBBZnRlcndhcmRzPC90aXRsZT4KIAogICAgPHBhcmE+CisKICAgICBXaGVuZXZl ciB5b3UgaGF2ZSBzaWduaWZpY2FudGx5IGFsdGVyZWQgdGhlIGRpc3RyaWJ1dGlvbiBvZiBk YXRhCiAgICAgd2l0aGluIGEgdGFibGUsIHJ1bm5pbmcgPGxpbmsgbGlua2VuZD0ic3FsLWFu YWx5emUiPjxjb21tYW5kPkFOQUxZWkU8L2NvbW1hbmQ+PC9saW5rPiBpcyBzdHJvbmdseSBy ZWNvbW1lbmRlZC4gVGhpcwogICAgIGluY2x1ZGVzIGJ1bGsgbG9hZGluZyBsYXJnZSBhbW91 bnRzIG9mIGRhdGEgaW50byB0aGUgdGFibGUuICBSdW5uaW5nCisKICAgICA8Y29tbWFuZD5B TkFMWVpFPC9jb21tYW5kPiAob3IgPGNvbW1hbmQ+VkFDVVVNIEFOQUxZWkU8L2NvbW1hbmQ+ KQogICAgIGVuc3VyZXMgdGhhdCB0aGUgcGxhbm5lciBoYXMgdXAtdG8tZGF0ZSBzdGF0aXN0 aWNzIGFib3V0IHRoZQogICAgIHRhYmxlLiAgV2l0aCBubyBzdGF0aXN0aWNzIG9yIG9ic29s ZXRlIHN0YXRpc3RpY3MsIHRoZSBwbGFubmVyIG1pZ2h0CmRpZmYgLS1naXQgYS9kb2Mvc3Jj L3NnbWwvcmVmL2FuYWx5emUuc2dtbCBiL2RvYy9zcmMvc2dtbC9yZWYvYW5hbHl6ZS5zZ21s CmluZGV4IGM4ZmNlYmMxNjEyLi5lYTc4ZjBkMDM4NyAxMDA2NDQKLS0tIGEvZG9jL3NyYy9z Z21sL3JlZi9hbmFseXplLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL3JlZi9hbmFseXplLnNn bWwKQEAgLTI1MCwyMiArMjUwLDMyIEBAIEFOQUxZWkUgWyBWRVJCT1NFIF0gWyA8cmVwbGFj ZWFibGUgY2xhc3M9InBhcmFtZXRlciI+dGFibGVfYW5kX2NvbHVtbnM8L3JlcGxhY2VhCiAg IDwvcGFyYT4KIAogICA8cGFyYT4KLSAgICBJZiB0aGUgdGFibGUgYmVpbmcgYW5hbHl6ZWQg aGFzIG9uZSBvciBtb3JlIGNoaWxkcmVuLAotICAgIDxjb21tYW5kPkFOQUxZWkU8L2NvbW1h bmQ+IHdpbGwgZ2F0aGVyIHN0YXRpc3RpY3MgdHdpY2U6IG9uY2Ugb24gdGhlCi0gICAgcm93 cyBvZiB0aGUgcGFyZW50IHRhYmxlIG9ubHksIGFuZCBhIHNlY29uZCB0aW1lIG9uIHRoZSBy b3dzIG9mIHRoZQotICAgIHBhcmVudCB0YWJsZSB3aXRoIGFsbCBvZiBpdHMgY2hpbGRyZW4u ICBUaGlzIHNlY29uZCBzZXQgb2Ygc3RhdGlzdGljcwotICAgIGlzIG5lZWRlZCB3aGVuIHBs YW5uaW5nIHF1ZXJpZXMgdGhhdCB0cmF2ZXJzZSB0aGUgZW50aXJlIGluaGVyaXRhbmNlCi0g ICAgdHJlZS4gIFRoZSBhdXRvdmFjdXVtIGRhZW1vbiwgaG93ZXZlciwgd2lsbCBvbmx5IGNv bnNpZGVyIGluc2VydHMgb3IKLSAgICB1cGRhdGVzIG9uIHRoZSBwYXJlbnQgdGFibGUgaXRz ZWxmIHdoZW4gZGVjaWRpbmcgd2hldGhlciB0byB0cmlnZ2VyIGFuCi0gICAgYXV0b21hdGlj IGFuYWx5emUgZm9yIHRoYXQgdGFibGUuICBJZiB0aGF0IHRhYmxlIGlzIHJhcmVseSBpbnNl cnRlZCBpbnRvCi0gICAgb3IgdXBkYXRlZCwgdGhlIGluaGVyaXRhbmNlIHN0YXRpc3RpY3Mg d2lsbCBub3QgYmUgdXAgdG8gZGF0ZSB1bmxlc3MgeW91Ci0gICAgcnVuIDxjb21tYW5kPkFO QUxZWkU8L2NvbW1hbmQ+IG1hbnVhbGx5LgorICAgIElmIHRoZSB0YWJsZSBiZWluZyBhbmFs eXplZCBpcyBwYXJ0aXRpb25lZCwgPGNvbW1hbmQ+QU5BTFlaRTwvY29tbWFuZD4KKyAgICB3 aWxsIGdhdGhlciBzdGF0aXN0aWNzIGJ5IHNhbXBsaW5nIGJsb2NrcyByYW5kb21seSBmcm9t IGl0cyBwYXJ0aXRpb25zOworICAgIGluIGFkZGl0aW9uLCBpdCB3aWxsIHJlY3Vyc2UgaW50 byBlYWNoIHBhcnRpdGlvbiBhbmQgdXBkYXRlIGl0cyBzdGF0aXN0aWNzLgorICAgIChIb3dl dmVyLCBpbiBtdWx0aS1sZXZlbCBwYXJ0aXRpb25pbmcgc2NlbmFyaW9zLCBlYWNoIGxlYWYg cGFydGl0aW9uCisgICAgd2lsbCBvbmx5IGJlIGFuYWx5emVkIG9uY2UuKQorICAgIEJ5IGNv bnN0cmFzdCwgaWYgdGhlIHRhYmxlIGJlaW5nIGFuYWx5emVkIGhhcyBpbmhlcml0YW5jZSBj aGlsZHJlbiwKKyAgICA8Y29tbWFuZD5BTkFMWVpFPC9jb21tYW5kPiB3aWxsIGdhdGhlciBz dGF0aXN0aWNzIGZvciBpdCB0d2ljZToKKyAgICBvbmNlIG9uIHRoZSByb3dzIG9mIHRoZSBw YXJlbnQgdGFibGUgb25seSwgYW5kIGEgc2Vjb25kIHRpbWUgb24gdGhlCisgICAgcm93cyBv ZiB0aGUgcGFyZW50IHRhYmxlIHdpdGggYWxsIG9mIGl0cyBjaGlsZHJlbi4gIFRoaXMgc2Vj b25kIHNldCBvZgorICAgIHN0YXRpc3RpY3MgaXMgbmVlZGVkIHdoZW4gcGxhbm5pbmcgcXVl cmllcyB0aGF0IHRyYXZlcnNlIHRoZSBlbnRpcmUKKyAgICBpbmhlcml0YW5jZSB0cmVlLiAg VGhlIGNoaWxkIHRhYmxlcyB0aGVtc2VsdmVzIGFyZSBub3QgaW5kaXZpZHVhbGx5CisgICAg YW5hbHl6ZWQgaW4gdGhpcyBjYXNlLgogICA8L3BhcmE+CiAKICAgPHBhcmE+Ci0gICAgSWYg YW55IG9mIHRoZSBjaGlsZCB0YWJsZXMgYXJlIGZvcmVpZ24gdGFibGVzIHdob3NlIGZvcmVp Z24gZGF0YSB3cmFwcGVycwotICAgIGRvIG5vdCBzdXBwb3J0IDxjb21tYW5kPkFOQUxZWkU8 L2NvbW1hbmQ+LCB0aG9zZSBjaGlsZCB0YWJsZXMgYXJlIGlnbm9yZWQgd2hpbGUKLSAgICBn YXRoZXJpbmcgaW5oZXJpdGFuY2Ugc3RhdGlzdGljcy4KKyAgICBUaGUgYXV0b3ZhY3V1bSBk YWVtb24gZG9lcyBub3QgcHJvY2VzcyBwYXJ0aXRpb25lZCB0YWJsZXMsIG5vciBkb2VzIGl0 CisgICAgcHJvY2VzcyBpbmhlcml0YW5jZSBwYXJlbnRzIGR1ZSB0byBtb2RpZmljYXRpb25z IHRvIGl0cyBjaGlsZCB0YWJsZXMuCisgICAgSXQgaXMgdXN1YWxseSBuZWNlc3NhcnkgdG8g cGVyaW9kaWNhbGx5IHJ1biBhIG1hbnVhbAorICAgIDxjb21tYW5kPkFOQUxZWkU8L2NvbW1h bmQ+IHRvIGtlZXAgdGhlIHN0YXRpc3RpY3Mgb2YgdGhlIHRhYmxlIGhpZXJhcmNoeQorICAg IHVwIHRvIGRhdGUuICBTZWUuLi4KKyAgPC9wYXJhPgorCisgIDxwYXJhPgorICAgIElmIGFu eSBjaGlsZCB0YWJsZXMgb3IgcGFydGl0aW9ucyBhcmUgZm9yZWlnbiB0YWJsZXMgd2hvc2Ug Zm9yZWlnbgorICAgIGRhdGEgd3JhcHBlcnMgZG8gbm90IHN1cHBvcnQgPGNvbW1hbmQ+QU5B TFlaRTwvY29tbWFuZD4sIHRob3NlIHRhYmxlcyBhcmUKKyAgICBpZ25vcmVkIHdoaWxlIGdh dGhlcmluZyBpbmhlcml0YW5jZSBzdGF0aXN0aWNzLgogICA8L3BhcmE+CiAKICAgPHBhcmE+ Ci0tIAoyLjMxLjEKCg== --------------OuCC0Acbd01hY41yA0TGsDOh Content-Type: text/x-patch; charset=UTF-8; name="v2-0002-minor-changes-rewordings.patch" Content-Disposition: attachment; filename="v2-0002-minor-changes-rewordings.patch" Content-Transfer-Encoding: base64 RnJvbSA5OTNhNDJlZTJjNzNhMTA5ODg0NTMxOWIzMDgxMWI1Yjc0OTdmMmY4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUb21hcyBWb25kcmEgPHRvbWFzLnZvbmRyYUBwb3N0 Z3Jlc3FsLm9yZz4KRGF0ZTogRnJpLCAyMSBKYW4gMjAyMiAxODowNTo1NiArMDEwMApTdWJq ZWN0OiBbUEFUQ0ggdjIgMi8yXSBtaW5vciBjaGFuZ2VzIC8gcmV3b3JkaW5ncwoKLS0tCiBk b2Mvc3JjL3NnbWwvbWFpbnRlbmFuY2Uuc2dtbCB8IDIwICsrKysrKysrKy0tLS0tLS0tLQog ZG9jL3NyYy9zZ21sL3BlcmZvcm0uc2dtbCAgICAgfCAgMiAtLQogZG9jL3NyYy9zZ21sL3Jl Zi9hbmFseXplLnNnbWwgfCAzOCArKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0t LQogMyBmaWxlcyBjaGFuZ2VkLCAzOCBpbnNlcnRpb25zKCspLCAyMiBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9kb2Mvc3JjL3NnbWwvbWFpbnRlbmFuY2Uuc2dtbCBiL2RvYy9zcmMv c2dtbC9tYWludGVuYW5jZS5zZ21sCmluZGV4IGI3YzgwNmNjOTA2Li4yMDg2ZGFlNjFiMiAx MDA2NDQKLS0tIGEvZG9jL3NyYy9zZ21sL21haW50ZW5hbmNlLnNnbWwKKysrIGIvZG9jL3Ny Yy9zZ21sL21haW50ZW5hbmNlLnNnbWwKQEAgLTI5MSwxMSArMjkxLDEyIEBACiAgICA8L3Bh cmE+CiAKICAgIDxwYXJhPgotICAgIFR1cGxlcyBjaGFuZ2VkIGluIHBhcnRpdGlvbnMgYW5k IGluaGVyaXRhbmNlIGNoaWxkcmVuIGRvIG5vdCBjb3VudCB0b3dhcmRzCisgICAgVHVwbGVz IGNoYW5nZWQgaW4gcGFydGl0aW9ucyBhbmQgaW5oZXJpdGFuY2UgY2hpbGRyZW4gZG8gbm90 IHRyaWdnZXIKICAgICBhbmFseXplIG9uIHRoZSBwYXJlbnQgdGFibGUuICBJZiB0aGUgcGFy ZW50IHRhYmxlIGlzIGVtcHR5IG9yIHJhcmVseQotICAgIGNoYW5nZWQsIGl0IG1heSBuZXZl ciBiZSBwcm9jZXNzZWQgYnkgYXV0b3ZhY3V1bS4gIEl0IGlzIG5lY2Vzc2FyeSB0bwotICAg IHBlcmlvZGljYWxseSBtYW51YWwgcnVuIDxjb21tYW5kPkFOQUxZWkU8L2NvbW1hbmQ+IG9u IHRoZSBwYXJlbnQgdGFibGUgdG8KLSAgICBrZWVwIHRoZSBzdGF0aXN0aWNzIG9mIGl0cyB0 YWJsZSBoaWVyYXJjaHkgdXAgdG8gZGF0ZS4KKyAgICBjaGFuZ2VkLCBpdCBtYXkgbmV2ZXIg YmUgcHJvY2Vzc2VkIGJ5IGF1dG92YWN1dW0sIGFuZCB0aGUgc3RhdGlzdGljcyBmb3IKKyAg ICB0aGUgaW5oZXJpdGFuY2UgdHJlZSBhcyBhIHdob2xlIHdvbid0IGJlIGNvbGxlY3RlZC4g SXQgaXMgbmVjZXNzYXJ5IHRvCisgICAgcnVuIDxjb21tYW5kPkFOQUxZWkU8L2NvbW1hbmQ+ IG9uIHRoZSBwYXJlbnQgdGFibGUgbWFudWFsbHksIHRvIGtlZXAKKyAgICB0aGUgc3RhdGlz dGljcyB1cCB0byBkYXRlLgogICAgPC9wYXJhPgogCiAgICA8cGFyYT4KQEAgLTM1OCwxMiAr MzU5LDEzIEBACiAKICAgIDx0aXA+CiAgICAgPHBhcmE+Ci0gICAgIFRoZSBhdXRvdmFjdXVt IGRhZW1vbiBkb2VzIG5vdCBpc3N1ZSA8Y29tbWFuZD5BTkFMWVpFPC9jb21tYW5kPiBjb21t YW5kcyBmb3IKLSAgICAgcGFydGl0aW9uZWQgdGFibGVzLiAgSW5oZXJpdGFuY2UgcGFyZW50 cyB3aWxsIG9ubHkgYmUgYW5hbHl6ZWQgaWYgdGhlCisgICAgIFRoZSBhdXRvdmFjdXVtIGRh ZW1vbiBtYXkgbm90IGlzc3VlIDxjb21tYW5kPkFOQUxZWkU8L2NvbW1hbmQ+IGNvbW1hbmRz CisgICAgIGZvciBwYXJ0aXRpb25lZCB0YWJsZXMuICBJbmhlcml0YW5jZSBwYXJlbnRzIHdp bGwgb25seSBiZSBhbmFseXplZCBpZiB0aGUKICAgICAgcGFyZW50IGl0c2VsZiBpcyBjaGFu Z2VkIC0gY2hhbmdlcyB0byBjaGlsZCB0YWJsZXMgZG8gbm90IHRyaWdnZXIKLSAgICAgYXV0 b2FuYWx5emUgb24gdGhlIHBhcmVudCB0YWJsZS4gIEl0IGlzIG5lY2Vzc2FyeSB0byBwZXJp b2RpY2FsbHkgcnVuIGEKLSAgICAgbWFudWFsIDxjb21tYW5kPkFOQUxZWkU8L2NvbW1hbmQ+ IHRvIGtlZXAgdGhlIHN0YXRpc3RpY3Mgb2YgdGhlIHRhYmxlCi0gICAgIGhpZXJhcmNoeSB1 cCB0byBkYXRlLgorICAgICBhdXRvYW5hbHl6ZSBvbiB0aGUgcGFyZW50IHRhYmxlLiAgSWYg eW91ciBxdWVyaWVzIHJlcXVpcmUgc3RhdGlzdGljcyBvbgorICAgICBwYXJlbnQgcmVsYXRp b25zIGZvciBwcm9wZXIgcGxhbm5pbmcsIGl0J3MgbmVjZXNzYXJ5IHRvIHBlcmlvZGljYWxs eSBydW4KKyAgICAgYSBtYW51YWwgPGNvbW1hbmQ+QU5BTFlaRTwvY29tbWFuZD4gb24gdGhv c2UgdGFibGVzIHRvIGtlZXAgdGhlIHN0YXRpc3RpY3MKKyAgICAgdXAgdG8gZGF0ZS4KICAg ICA8L3BhcmE+CiAgICA8L3RpcD4KIApkaWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21sL3BlcmZv cm0uc2dtbCBiL2RvYy9zcmMvc2dtbC9wZXJmb3JtLnNnbWwKaW5kZXggYjg0ODUzZmQ2ZmYu Ljg5ZmY1ODMzOGU1IDEwMDY0NAotLS0gYS9kb2Mvc3JjL3NnbWwvcGVyZm9ybS5zZ21sCisr KyBiL2RvYy9zcmMvc2dtbC9wZXJmb3JtLnNnbWwKQEAgLTE3NjUsMTEgKzE3NjUsOSBAQCBT RUxFQ1QgKiBGUk9NIHgsIHksIGEsIGIsIGMgV0hFUkUgc29tZXRoaW5nIEFORCBzb21ldGhp bmdlbHNlOwogICAgPHRpdGxlPlJ1biA8Y29tbWFuZD5BTkFMWVpFPC9jb21tYW5kPiBBZnRl cndhcmRzPC90aXRsZT4KIAogICAgPHBhcmE+Ci0KICAgICBXaGVuZXZlciB5b3UgaGF2ZSBz aWduaWZpY2FudGx5IGFsdGVyZWQgdGhlIGRpc3RyaWJ1dGlvbiBvZiBkYXRhCiAgICAgd2l0 aGluIGEgdGFibGUsIHJ1bm5pbmcgPGxpbmsgbGlua2VuZD0ic3FsLWFuYWx5emUiPjxjb21t YW5kPkFOQUxZWkU8L2NvbW1hbmQ+PC9saW5rPiBpcyBzdHJvbmdseSByZWNvbW1lbmRlZC4g VGhpcwogICAgIGluY2x1ZGVzIGJ1bGsgbG9hZGluZyBsYXJnZSBhbW91bnRzIG9mIGRhdGEg aW50byB0aGUgdGFibGUuICBSdW5uaW5nCi0KICAgICA8Y29tbWFuZD5BTkFMWVpFPC9jb21t YW5kPiAob3IgPGNvbW1hbmQ+VkFDVVVNIEFOQUxZWkU8L2NvbW1hbmQ+KQogICAgIGVuc3Vy ZXMgdGhhdCB0aGUgcGxhbm5lciBoYXMgdXAtdG8tZGF0ZSBzdGF0aXN0aWNzIGFib3V0IHRo ZQogICAgIHRhYmxlLiAgV2l0aCBubyBzdGF0aXN0aWNzIG9yIG9ic29sZXRlIHN0YXRpc3Rp Y3MsIHRoZSBwbGFubmVyIG1pZ2h0CmRpZmYgLS1naXQgYS9kb2Mvc3JjL3NnbWwvcmVmL2Fu YWx5emUuc2dtbCBiL2RvYy9zcmMvc2dtbC9yZWYvYW5hbHl6ZS5zZ21sCmluZGV4IGVhNzhm MGQwMzg3Li4xNDgyZmMyZDRiYiAxMDA2NDQKLS0tIGEvZG9jL3NyYy9zZ21sL3JlZi9hbmFs eXplLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21sL3JlZi9hbmFseXplLnNnbWwKQEAgLTI1MCwx OCArMjUwLDM0IEBAIEFOQUxZWkUgWyBWRVJCT1NFIF0gWyA8cmVwbGFjZWFibGUgY2xhc3M9 InBhcmFtZXRlciI+dGFibGVfYW5kX2NvbHVtbnM8L3JlcGxhY2VhCiAgIDwvcGFyYT4KIAog ICA8cGFyYT4KLSAgICBJZiB0aGUgdGFibGUgYmVpbmcgYW5hbHl6ZWQgaXMgcGFydGl0aW9u ZWQsIDxjb21tYW5kPkFOQUxZWkU8L2NvbW1hbmQ+Ci0gICAgd2lsbCBnYXRoZXIgc3RhdGlz dGljcyBieSBzYW1wbGluZyBibG9ja3MgcmFuZG9tbHkgZnJvbSBpdHMgcGFydGl0aW9uczsK LSAgICBpbiBhZGRpdGlvbiwgaXQgd2lsbCByZWN1cnNlIGludG8gZWFjaCBwYXJ0aXRpb24g YW5kIHVwZGF0ZSBpdHMgc3RhdGlzdGljcy4KLSAgICAoSG93ZXZlciwgaW4gbXVsdGktbGV2 ZWwgcGFydGl0aW9uaW5nIHNjZW5hcmlvcywgZWFjaCBsZWFmIHBhcnRpdGlvbgotICAgIHdp bGwgb25seSBiZSBhbmFseXplZCBvbmNlLikKKyAgICBJZiB0aGUgdGFibGUgYmVpbmcgYW5h bHl6ZWQgaGFzIG9uZSBvciBtb3JlIGNoaWxkcmVuLAorICAgIDxjb21tYW5kPkFOQUxZWkU8 L2NvbW1hbmQ+IHdpbGwgZ2F0aGVyIHN0YXRpc3RpY3MgdHdpY2U6IG9uY2Ugb24gdGhlCisg ICAgcm93cyBvZiB0aGUgcGFyZW50IHRhYmxlIG9ubHksIGFuZCBhIHNlY29uZCB0aW1lIG9u IHRoZSByb3dzIG9mIHRoZQorICAgIHBhcmVudCB0YWJsZSB3aXRoIGFsbCBvZiBpdHMgY2hp bGRyZW4uICBUaGlzIHNlY29uZCBzZXQgb2Ygc3RhdGlzdGljcworICAgIGlzIG5lZWRlZCB3 aGVuIHBsYW5uaW5nIHF1ZXJpZXMgdGhhdCB0cmF2ZXJzZSB0aGUgZW50aXJlIGluaGVyaXRh bmNlCisgICAgdHJlZS4gIFRoZSBhdXRvdmFjdXVtIGRhZW1vbiwgaG93ZXZlciwgd2lsbCBv bmx5IGNvbnNpZGVyIGluc2VydHMgb3IKKyAgICB1cGRhdGVzIG9uIHRoZSBwYXJlbnQgdGFi bGUgaXRzZWxmIHdoZW4gZGVjaWRpbmcgd2hldGhlciB0byB0cmlnZ2VyIGFuCisgICAgYXV0 b21hdGljIGFuYWx5emUgZm9yIHRoYXQgdGFibGUuICBJZiB0aGF0IHRhYmxlIGlzIHJhcmVs eSBpbnNlcnRlZCBpbnRvCisgICAgb3IgdXBkYXRlZCwgdGhlIGluaGVyaXRhbmNlIHN0YXRp c3RpY3Mgd2lsbCBub3QgYmUgdXAgdG8gZGF0ZSB1bmxlc3MgeW91CisgICAgcnVuIDxjb21t YW5kPkFOQUxZWkU8L2NvbW1hbmQ+IG1hbnVhbGx5LgorICA8L3BhcmE+CisKKyAgPHBhcmE+ CisgICAgRm9yIHBhcnRpdGlvbmVkIHRhYmxlcywgPGNvbW1hbmQ+QU5BTFlaRTwvY29tbWFu ZD4gZ2F0aGVycyBzdGF0aXN0aWNzIGJ5CisgICAgc2FtcGxpbmcgcm93cyBmcm9tIGFsbCBw YXJ0aXRpb25zOyBpbiBhZGRpdGlvbiwgaXQgd2lsbCByZWN1cnNlIGludG8gZWFjaAorICAg IHBhcnRpdGlvbiBhbmQgdXBkYXRlIGl0cyBzdGF0aXN0aWNzLiAgRWFjaCBsZWFmIHBhcnRp dGlvbiBpcyBhbmFseXplZCBvbmx5CisgICAgb25jZSwgZXZlbiB3aXRoIG11bHRpLWxldmVs IHBhcnRpdGlvbmluZy4gIE5vIHN0YXRpc3RpY3MgYXJlIGNvbGxlY3RlZCBmb3IKKyAgICB0 aGUgcGFyZW50IHRhYmxlIChpZ25vcmluZyBkYXRhIGZyb20gcGFydGl0aW9ucyksIGJlY2F1 c2Ugd2l0aCBwYXJ0aXRpb25pbmcKKyAgICBpdCdzIGd1YXJhbnRlZWQgdG8gYmUgZW1wdHku CisgIDwvcGFyYT4KKworICA8cGFyYT4KICAgICBCeSBjb25zdHJhc3QsIGlmIHRoZSB0YWJs ZSBiZWluZyBhbmFseXplZCBoYXMgaW5oZXJpdGFuY2UgY2hpbGRyZW4sCi0gICAgPGNvbW1h bmQ+QU5BTFlaRTwvY29tbWFuZD4gd2lsbCBnYXRoZXIgc3RhdGlzdGljcyBmb3IgaXQgdHdp Y2U6Ci0gICAgb25jZSBvbiB0aGUgcm93cyBvZiB0aGUgcGFyZW50IHRhYmxlIG9ubHksIGFu ZCBhIHNlY29uZCB0aW1lIG9uIHRoZQotICAgIHJvd3Mgb2YgdGhlIHBhcmVudCB0YWJsZSB3 aXRoIGFsbCBvZiBpdHMgY2hpbGRyZW4uICBUaGlzIHNlY29uZCBzZXQgb2YKLSAgICBzdGF0 aXN0aWNzIGlzIG5lZWRlZCB3aGVuIHBsYW5uaW5nIHF1ZXJpZXMgdGhhdCB0cmF2ZXJzZSB0 aGUgZW50aXJlCi0gICAgaW5oZXJpdGFuY2UgdHJlZS4gIFRoZSBjaGlsZCB0YWJsZXMgdGhl bXNlbHZlcyBhcmUgbm90IGluZGl2aWR1YWxseQotICAgIGFuYWx5emVkIGluIHRoaXMgY2Fz ZS4KKyAgICA8Y29tbWFuZD5BTkFMWVpFPC9jb21tYW5kPiBnYXRoZXJzIHR3byBzZXRzIG9m IHN0YXRpc3RpY3M6IG9uY2Ugb24gdGhlIHJvd3MKKyAgICBvZiB0aGUgcGFyZW50IHRhYmxl IG9ubHksIGFuZCBhIHNlY29uZCBvbmUgaW5jbHVkaW5nIHJvd3Mgb2YgYm90aCB0aGUgcGFy ZW50CisgICAgdGFibGUgYW5kIGFsbCBjaGlsZCByZWxhdGlvbnMuICBUaGlzIHNlY29uZCBz ZXQgb2Ygc3RhdGlzdGljcyBpcyBuZWVkZWQgd2hlbgorICAgIHBsYW5uaW5nIHF1ZXJpZXMg dGhhdCBwcm9jZXNzIHRoZSB3aG9sZSBpbmhlcml0YW5jZSB0cmVlIGF0IG9uY2UuICBUaGUg Y2hpbGQKKyAgICB0YWJsZXMgdGhlbXNlbHZlcyBhcmUgbm90IGluZGl2aWR1YWxseSBhbmFs eXplZCBpbiB0aGlzIGNhc2UuCiAgIDwvcGFyYT4KIAogICA8cGFyYT4KLS0gCjIuMzEuMQoK --------------OuCC0Acbd01hY41yA0TGsDOh--