From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Lakhin <exclusion@gmail.com>
cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: HEAPDEBUGALL is broken
In-reply-to: <8936216c-3492-3f6e-634b-d638fddc5f91@gmail.com>
References: <645c0646-4218-d4c3-409a-a7003a0c108d@2ndquadrant.com>
 <3070eb7d-e06d-31a0-5b68-4ae088fd146c@gmail.com>
 <cffb7d94-e7f4-6d45-bd0b-7cca9e2796fb@2ndquadrant.com>
 <8936216c-3492-3f6e-634b-d638fddc5f91@gmail.com>
Comments: In-reply-to Alexander Lakhin <exclusion@gmail.com>
	message dated "Wed, 22 Apr 2020 07:00:00 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6829.1587565191.1@sss.pgh.pa.us>
Date: Wed, 22 Apr 2020 10:19:51 -0400
Message-ID: <6830.1587565191@sss.pgh.pa.us>
Precedence: bulk

Alexander Lakhin <exclusion@gmail.com> writes:
> 21.04.2020 21:01, Peter Eisentraut wrote:
>> Do you have a proposed patch?

> As this is broken at least since the invention of the generational
> allocator (2017-11-23, a4ccc1ce), I believe than no one uses this (and
> slab is broken too). Nonetheless, HAVE_ALLOCINFO in aset.c is still
> working, so it could be leaved alone, though the output too chatty for
> general use (`make check` produces postmaster log of size 3.8GB). I
> think someone would still need to insert some extra conditions to use
> that or find another way to debug memory allocations.

> So I would just remove this debug macro. The proposed patch is attached.

I didn't review this in close detail, but I think it's a good idea.
We have better memory-use-analysis tools these days, such as valgrind,
so it's no surprise that nobody is using this old code.

			regards, tom lane