From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@lists.postgresql.org
Subject: Retiring pg_regress' --load-language option
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----- =_aaaaaaaaaa0"
Content-ID: <6797.1581627304.0@sss.pgh.pa.us>
Date: Thu, 13 Feb 2020 15:56:33 -0500
Message-ID: <6853.1581627393@sss.pgh.pa.us>
Precedence: bulk

------- =_aaaaaaaaaa0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6797.1581627304.1@sss.pgh.pa.us>

pg_regress' --load-language option has been unused in the core code since
we introduced extensions in 9.1; all callers now use --load-extension
instead.  It's a fairly safe bet that it's never been used by any non-core
code, since it could only work for languages listed in pg_pltemplate.
The last possible reason to use it expired with commit 50fc694e4, which
removed pg_pltemplate and made parameterless CREATE LANGUAGE equivalent
to CREATE EXTENSION.  So I think we might as well kill it, as per the
attached trivial patch.  Any objections?

			regards, tom lane


------- =_aaaaaaaaaa0
Content-Type: text/x-diff; name="remove-load-language-option.patch";
	charset="us-ascii"
Content-ID: <6797.1581627304.2@sss.pgh.pa.us>
Content-Description: remove-load-language-option.patch
Content-Transfer-Encoding: quoted-printable

diff --git a/src/test/regress/pg_regress.c b/src/test/regress/pg_regress.c
index 92bd28d..9a4e52b 100644
--- a/src/test/regress/pg_regress.c
+++ b/src/test/regress/pg_regress.c
@@ -76,7 +76,6 @@ char	   *inputdir =3D ".";
 char	   *outputdir =3D ".";
 char	   *bindir =3D PGBINDIR;
 char	   *launcher =3D NULL;
-static _stringlist *loadlanguage =3D NULL;
 static _stringlist *loadextension =3D NULL;
 static int	max_connections =3D 0;
 static int	max_concurrent_tests =3D 0;
@@ -1998,16 +1997,6 @@ create_database(const char *dbname)
 				 dbname, dbname, dbname, dbname, dbname, dbname);
 =

 	/*
-	 * Install any requested procedural languages.  We use CREATE OR REPLACE
-	 * so that this will work whether or not the language is preinstalled.
-	 */
-	for (sl =3D loadlanguage; sl !=3D NULL; sl =3D sl->next)
-	{
-		header(_("installing %s"), sl->str);
-		psql_command(dbname, "CREATE OR REPLACE LANGUAGE \"%s\"", sl->str);
-	}
-
-	/*
 	 * Install any requested extensions.  We use CREATE IF NOT EXISTS so tha=
t
 	 * this will work whether or not the extension is preinstalled.
 	 */
@@ -2058,8 +2047,6 @@ help(void)
 	printf(_("      --launcher=3DCMD            use CMD as launcher of psql\=
n"));
 	printf(_("      --load-extension=3DEXT      load the named extension bef=
ore running the\n"));
 	printf(_("                                tests; can appear multiple tim=
es\n"));
-	printf(_("      --load-language=3DLANG      load the named language befo=
re running the\n"));
-	printf(_("                                tests; can appear multiple tim=
es\n"));
 	printf(_("      --max-connections=3DN       maximum number of concurrent=
 connections\n"));
 	printf(_("                                (default is 0, meaning unlimit=
ed)\n"));
 	printf(_("      --max-concurrent-tests=3DN  maximum number of concurrent=
 tests in schedule\n"));
@@ -2096,7 +2083,6 @@ regression_main(int argc, char *argv[], init_functio=
n ifunc, test_function tfunc
 		{"dbname", required_argument, NULL, 1},
 		{"debug", no_argument, NULL, 2},
 		{"inputdir", required_argument, NULL, 3},
-		{"load-language", required_argument, NULL, 4},
 		{"max-connections", required_argument, NULL, 5},
 		{"encoding", required_argument, NULL, 6},
 		{"outputdir", required_argument, NULL, 7},
@@ -2172,9 +2158,6 @@ regression_main(int argc, char *argv[], init_functio=
n ifunc, test_function tfunc
 			case 3:
 				inputdir =3D pg_strdup(optarg);
 				break;
-			case 4:
-				add_stringlist_item(&loadlanguage, optarg);
-				break;
 			case 5:
 				max_connections =3D atoi(optarg);
 				break;

------- =_aaaaaaaaaa0--