From: Antonin Houska <ah@cybertec.at>
To: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
    Pg Hackers <pgsql-hackers@lists.postgresql.org>,
    Robert Treat <rob@xzilla.net>
Subject: Re: Adding REPACK [concurrently]
In-reply-to: <83637.1772472210@localhost>
References: <202602251618.dpgvox64vziz@alvherre.pgsql>
 <97234.1772046253@localhost> <87648.1772217509@localhost>
 <CADzfLwWC8gk5CPTjthN873KKGWsTqOnfEx2Z_2Nr6i=V8Y70Kw@mail.gmail.com>
 <67772.1772462341@localhost> <83637.1772472210@localhost>
Comments: In-reply-to Antonin Houska <ah@cybertec.at>
   message dated "Mon, 02 Mar 2026 18:23:30 +0100."
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Date: Thu, 05 Mar 2026 20:06:13 +0100
Message-ID: <68571.1772737573@localhost>
Archived-At: 
 <https://www.postgresql.org/message-id/68571.1772737573%40localhost>
Precedence: bulk

--=-=-=
Content-Type: text/plain

Antonin Houska <ah@cybertec.at> wrote:

> Antonin Houska <ah@cybertec.at> wrote:
> 
> > Mihail Nikalayeu <mihailnikalayeu@gmail.com> wrote:
> > > ------------
> > > 
> > > > attrs = palloc0_array(Datum, desc->natts);
> > > > isnull = palloc0_array(bool, desc->natts);
> > > 
> > > It looks like there is a memory leak with those arrays.
> > 
> > I suppose you mean store_change(). Yes, I tried to free the individual chunks
> > and forgot these. The next version uses a new, per-change memory context.
> 
> I realize now that I forgot to reset the context at the end of the
> function. I'll fix that in the next version (which will probably be posted
> rather soon).

This is it. One more diff added, to engage BulkInsertState.

-- 
Antonin Houska
Web: https://www.cybertec-postgresql.com


--=-=-=
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment; filename=v38-0001-Add-REPACK-command.patch
Content-Transfer-Encoding: quoted-printable