From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Julien Rouhaud <rjuju123@gmail.com>,
        Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
        Michael Paquier <michael@paquier.xyz>,
        Robert Haas <robertmhaas@gmail.com>,
        Laurenz Albe <laurenz.albe@cybertec.at>,
        Douglas Doole <dougdoole@gmail.com>, Christoph Berg <myon@debian.org>,
        Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Collation versioning
In-reply-to: 
 <CA+hUKG+U_VV-7ZuJq0+sx5vwGYsUaeWSTxVUHc5ogeXJxJtAUw@mail.gmail.com>
References: <20200813095204.f7mlgdzsbaxa3mzr@nol>
 <CA+hUKGLP-aW+K_PUCPbTy=g18yC=7UjurXXwiqYwTbtj3SwukA@mail.gmail.com>
 <20200814073746.GF2057@paquier.xyz> <20200814090235.ifld2qvaw43pzpzg@nol>
 <20200907031741.GK2455@paquier.xyz> <20200908144507.GA57691@nol>
 <c3324b4e-095d-8de9-c3ba-7b468bb5b0b4@2ndquadrant.com>
 <CAOBaU_ashTn3Hq2fQ7fZDaYy7yQSZEQnpTRHzfjOZPPyeKybow@mail.gmail.com>
 <CA+hUKGKop8pe3ijVna6ZUA3cGdjy8egm5geUuPJqM91smjLjYQ@mail.gmail.com>
 <CAOBaU_aauaDbKnSr8jhusOUoD0GiUQ79WRB+pun35Fx+_h66aQ@mail.gmail.com>
 <20200924094854.abjmpfqixq6xd4o5@nol>
 <CA+hUKGKHj4aYmmwKZdZjkD=CWRmn=e6UsS7S+u6oLrrp0orgsw@mail.gmail.com>
 <CAOBaU_b1nmVh4gbj4DG_+=o6cgNqOS_EvJTsGEp4M+DDB1rMtA@mail.gmail.com>
 <CA+hUKGLnLVQyi=6koWHSc+qnoDwvV8SfTXgO6VdJwJ7vCHtLUA@mail.gmail.com>
 <CAOBaU_aXmNQmS1HqM2TyG-TKaxW9dyEGHyTsGkR7-=2-+Zh=wA@mail.gmail.com>
 <CAOBaU_aOUHQ4nevV9Q6Gan2bDhMbGUdvwOe+o=XBJTp5ptoGcQ@mail.gmail.com>
 <CA+hUKGLgzE_KOFGnryYACHhaNp8XKCLZYcNFu+J=0rEt702TpQ@mail.gmail.com>
 <CA+hUKG+JrRdBVBv!
 SZLvhAOnTcBF6CASj9BkUjyq9OqG2=BErrw@mail.gmail.com>
 <CAOBaU_YHbuMbwDNNjCHcA6-qyRVeR1j6qFehA1gnz+bM3UZJNA@mail.gmail.com>
 <CA+hUKGKa+22oiAsKcBTzxzsMtFw4MedjiBESO2nS2FndNaHjPA@mail.gmail.com>
 <CAOBaU_a2s4kek+HELEkAa9Y5CA+W+2dS-e7F8K6BNWuh7=xaqg@mail.gmail.com>
 <CA+hUKGLWDWBL+79jNAz3oMofp1WDjQbBrmZTMe4E-b-MioQU0A@mail.gmail.com>
 <CAOBaU_ZYyxQ3sJR932NFs5HHh++RqXDGwe1S5ubBv8nmsHXCog@mail.gmail.com>
 <CA+hUKG+U_VV-7ZuJq0+sx5vwGYsUaeWSTxVUHc5ogeXJxJtAUw@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Tue, 03 Nov 2020 02:38:31 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <686358.1604339499.1@sss.pgh.pa.us>
Date: Mon, 02 Nov 2020 12:51:39 -0500
Message-ID: <686359.1604339499@sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> Hmm, a failure from dory (WIndows) during pg_upgrade:

> performing post-bootstrap initialization ... 2020-11-02 08:08:22.213
> EST [5392] FATAL:  could not get collation version for locale
> "English_United States.1252": error code 87

> 87 means invalid parameter.  I'm surprised it got through various
> other tests and then failed here.  Whelk (also Windows) passed using
> "German_Germany.1252".  Hmm.  I'll wait for more Windows systems to
> report.

drongo just did it too, and it seems repeatable on dory.  I'm not 100%
sure, but I think the buildfarm's initial "check" step may be run under C
locale while pg_upgrade sees whatever the machine's prevailing locale is.
If that's correct, it seems like the simplest explanation is just that
extraction of a collation version is busted for (some?) non-C locales on
Windows.  Could be something as dumb as spaces in the locale name
being problematic.

			regards, tom lane