Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rka0r-00Dm0V-F0 for pgsql-hackers@arkaria.postgresql.org; Thu, 14 Mar 2024 01:36:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rka0o-00EFtY-Ka for pgsql-hackers@arkaria.postgresql.org; Thu, 14 Mar 2024 01:36:03 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rka0o-00EFtQ-6r for pgsql-hackers@lists.postgresql.org; Thu, 14 Mar 2024 01:36:02 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rka0f-004NQf-Id for pgsql-hackers@postgresql.org; Thu, 14 Mar 2024 01:36:01 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 297F82FFCB1E for ; Thu, 14 Mar 2024 02:35:51 +0100 (CET) Received: from s981.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id 197062E27DD0; Thu, 14 Mar 2024 02:35:51 +0100 (CET) Received: from s472.loopia.se (unknown [172.22.191.6]) by s981.loopia.se (Postfix) with ESMTP id 17D0A22B169E; Thu, 14 Mar 2024 02:35:51 +0100 (CET) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.21 X-Spam-Level: X-Spam-Status: No, score=-1.21 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, T_SCC_BODY_TEXT_LINE=-0.01] autolearn=disabled Authentication-Results: s472.loopia.se (amavisd-new); dkim=pass (2048-bit key) header.d=proxel.se Received: from s979.loopia.se ([172.22.191.5]) by s472.loopia.se (s472.loopia.se [172.22.190.12]) (amavisd-new, port 10024) with LMTP id snvpVyIsGjj2; Thu, 14 Mar 2024 02:35:50 +0100 (CET) X-Loopia-Auth: user X-Loopia-User: andreas@proxel.se X-Loopia-Originating-IP: 147.28.75.140 Received: from [192.168.0.121] (customer-147-28-75-140.stosn.net [147.28.75.140]) (Authenticated sender: andreas@proxel.se) by s979.loopia.se (Postfix) with ESMTPSA id 710E810BC346; Thu, 14 Mar 2024 02:35:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proxel.se; s=loopiadkim1707418970; t=1710380150; bh=yPrMI9iGC1y/9cWFziMDW0KDxSfLlkrqmBAhJV18g/8=; h=Date:Subject:From:To:References:In-Reply-To; b=q7kZ7rNd2Wa6s5xGxllh6i3t548e6WLNM6NA3F0FhBQL41FCT48Xaq317pfsdvWmq fjva10VQHH1mUKSX/DzT3nx34+84o1tJqzXvZaQNDPTMVQDxmhRhKl84dAhjF96uKb nFxiUWYjih3fBgc+WwU999fWQhuCkylvUkcm4DKJ1i/p6fuZ3gG7KkdphQe7z5iluq 2fL/CrcnmqpUCf3vK9ThMvsVbbmRrmaovBpLeu5Tu/IAQx1E9Qq9mgm7ejEEIAPY60 WT9Fu1uSOujfOhBXaKBsQOA1cJrdi3TpWnbvxbexOHll+4T4/+OUrBSRVudmUz/NdQ uDxKH5W+2e+6Q== Message-ID: <68783b20-60e9-4adb-a7be-74c70daa626e@proxel.se> Date: Thu, 14 Mar 2024 02:33:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Put genbki.pl output into src/include/catalog/ directly Content-Language: en-US From: Andreas Karlsson To: Peter Eisentraut , pgsql-hackers References: <21b74bdc-183d-4dd5-9c27-9378d178f459@eisentraut.org> <640bfcf4-bd2b-40ac-b38b-f2d464a57f83@proxel.se> In-Reply-To: <640bfcf4-bd2b-40ac-b38b-f2d464a57f83@proxel.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/13/24 12:41 PM, Andreas Karlsson wrote: > On 2/8/24 8:58 AM, Peter Eisentraut wrote: >> I think keeping the two build systems aligned this way will be useful >> for longer-term maintenance. > > Agreed, so started reviewing the patch. Attached is a rebased version of > the patch to solve a conflict. I have reviewed the patch now and would say it looks good. I like how we remove the symlinks plus make things more similar to the meson build so I think we should merge this. I tried building, running tests, running make clean, running make install and tried building with meson (plus checking that meson really checks for the generated files and actually refuse to build). Everything worked as expected. The code changes look clean and mostly consist of moving code. I personally think this is ready for committer. Andreas