public inbox for [email protected]
help / color / mirror / Atom feedFrom: Oleg Tselebrovskiy <[email protected]>
To: [email protected]
Subject: [PROPOSAL] Skip test citext_utf8 on Windows
Date: Mon, 11 Mar 2024 15:21:11 +0700
Message-ID: <[email protected]> (raw)
Greetings, everyone!
While running "installchecks" on databases with UTF-8 encoding the test
citext_utf8 fails because of Turkish dotted I like this:
SELECT 'i'::citext = 'İ'::citext AS t;
t
---
- t
+ f
(1 row)
I tried to replicate the test's results by hand and with any collation
that I tried (including --locale="Turkish") this test failed
Also an interesing result of my tesing. If you initialize you DB
with -E utf-8 --locale="Turkish" and then run select LOWER('İ');
the output will be this:
lower
-------
İ
(1 row)
Which I find strange since lower() uses collation that was passed
(default in this case but still)
My PostgreSQL version is this:
postgres=# select version();
version
----------------------------------------------------------------------
PostgreSQL 17devel on x86_64-windows, compiled by gcc-13.1.0, 64-bit
The proposed patch for skipping test is attached
Oleg Tselebrovskiy, Postgres Pro
Attachments:
[text/x-diff] skip_citext_utf8.patch (3.7K, ../[email protected]/2-skip_citext_utf8.patch)
download | inline diff:
��d i f f - - g i t a / c o n t r i b / c i t e x t / e x p e c t e d / c i t e x t _ u t f 8 . o u t b / c o n t r i b / c i t e x t / e x p e c t e d / c i t e x t _ u t f 8 . o u t
i n d e x 5 d 9 8 8 d c d 4 8 5 . . 6 c 4 0 6 9 f 9 4 6 9 1 0 0 6 4 4
- - - a / c o n t r i b / c i t e x t / e x p e c t e d / c i t e x t _ u t f 8 . o u t
+ + + b / c o n t r i b / c i t e x t / e x p e c t e d / c i t e x t _ u t f 8 . o u t
@ @ - 1 0 , 7 + 1 0 , 8 @ @
S E L E C T g e t d a t a b a s e e n c o d i n g ( ) < > ' U T F 8 ' O R
( S E L E C T ( d a t l o c p r o v i d e r = ' c ' A N D d a t c t y p e = ' C ' ) O R d a t l o c p r o v i d e r = ' i '
F R O M p g _ d a t a b a s e
- W H E R E d a t n a m e = c u r r e n t _ d a t a b a s e ( ) )
+ W H E R E d a t n a m e = c u r r e n t _ d a t a b a s e ( ) ) O R
+ ( v e r s i o n ( ) ~ ' w i n d o w s ' O R v e r s i o n ( ) ~ ' V i s u a l C \ + \ + ' O R v e r s i o n ( ) ~ ' m i n g w 3 2 ' )
A S s k i p _ t e s t \ g s e t
\ i f : s k i p _ t e s t
\ q u i t
d i f f - - g i t a / c o n t r i b / c i t e x t / e x p e c t e d / c i t e x t _ u t f 8 _ 1 . o u t b / c o n t r i b / c i t e x t / e x p e c t e d / c i t e x t _ u t f 8 _ 1 . o u t
i n d e x 7 0 6 5 a 5 d a 1 9 0 . . d 4 4 7 2 b 1 c 3 6 a 1 0 0 6 4 4
- - - a / c o n t r i b / c i t e x t / e x p e c t e d / c i t e x t _ u t f 8 _ 1 . o u t
+ + + b / c o n t r i b / c i t e x t / e x p e c t e d / c i t e x t _ u t f 8 _ 1 . o u t
@ @ - 1 0 , 7 + 1 0 , 8 @ @
S E L E C T g e t d a t a b a s e e n c o d i n g ( ) < > ' U T F 8 ' O R
( S E L E C T ( d a t l o c p r o v i d e r = ' c ' A N D d a t c t y p e = ' C ' ) O R d a t l o c p r o v i d e r = ' i '
F R O M p g _ d a t a b a s e
- W H E R E d a t n a m e = c u r r e n t _ d a t a b a s e ( ) )
+ W H E R E d a t n a m e = c u r r e n t _ d a t a b a s e ( ) ) O R
+ ( v e r s i o n ( ) ~ ' w i n d o w s ' O R v e r s i o n ( ) ~ ' V i s u a l C \ + \ + ' O R v e r s i o n ( ) ~ ' m i n g w 3 2 ' )
A S s k i p _ t e s t \ g s e t
\ i f : s k i p _ t e s t
\ q u i t
d i f f - - g i t a / c o n t r i b / c i t e x t / s q l / c i t e x t _ u t f 8 . s q l b / c o n t r i b / c i t e x t / s q l / c i t e x t _ u t f 8 . s q l
i n d e x 3 4 b 2 3 2 d 6 4 e 2 . . 5 3 7 7 5 c d c d 3 5 1 0 0 6 4 4
- - - a / c o n t r i b / c i t e x t / s q l / c i t e x t _ u t f 8 . s q l
+ + + b / c o n t r i b / c i t e x t / s q l / c i t e x t _ u t f 8 . s q l
@ @ - 1 1 , 7 + 1 1 , 8 @ @
S E L E C T g e t d a t a b a s e e n c o d i n g ( ) < > ' U T F 8 ' O R
( S E L E C T ( d a t l o c p r o v i d e r = ' c ' A N D d a t c t y p e = ' C ' ) O R d a t l o c p r o v i d e r = ' i '
F R O M p g _ d a t a b a s e
- W H E R E d a t n a m e = c u r r e n t _ d a t a b a s e ( ) )
+ W H E R E d a t n a m e = c u r r e n t _ d a t a b a s e ( ) ) O R
+ ( v e r s i o n ( ) ~ ' w i n d o w s ' O R v e r s i o n ( ) ~ ' V i s u a l C \ + \ + ' O R v e r s i o n ( ) ~ ' m i n g w 3 2 ' )
A S s k i p _ t e s t \ g s e t
\ i f : s k i p _ t e s t
\ q u i t
view thread (2+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: [PROPOSAL] Skip test citext_utf8 on Windows
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox