Subject: Re: pgbench - compute & show latency consistently
To: Fabien COELHO <coelho@cri.ensmp.fr>,
 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
References: <alpine.DEB.2.20.1607091035530.3412@sto>
 <dbddbaf3-0e93-044b-93ce-ded8d421f263@2ndquadrant.com>
 <alpine.DEB.2.20.1607131015370.7486@sto>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
From: Heikki Linnakangas <hlinnaka@iki.fi>
Message-ID: <68f175fc-9a7d-825b-e573-63d998ced452@iki.fi>
Date: Wed, 21 Sep 2016 13:30:27 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Icedove/45.2.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1607131015370.7486@sto>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

On 07/13/2016 11:39 AM, Fabien COELHO wrote:
>>>  number of transactions per client: 1000
>>> -latency average = 15.844 ms
>>> +latency average: 15.844 ms
>>>  tps = 618.764555 (including connections establishing)
>>
>> I think what you have here is that colons separate input parameters and
>> equal signs separate result output.  So I think it's OK the way it is.
>
> Hmmm... Then other measures displayed are not all consistent with this
> theory.
>
> Also there is still the bug under -t which displays a 0 latency.
>
> The attached patch still fixes that and make it consistent the other way
> around, i.e. by using "=" for latency. I switched to use ":" for weight
> which is an input parameter. I let ":" when there is a long sentence to
> describe the figure displayed, more on aesthetical grounds.

Committed, thanks!

- Heikki


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers