Message-ID: <69005b14-a48f-4165-becd-22b14b7a5ec3@postgresfriends.org>
Date: Wed, 18 Oct 2023 15:04:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: run pgindent on a regular basis / scripted manner
To: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>, Andres Freund <andres@anarazel.de>,
 Andrew Dunstan <andrew@dunslane.net>, Jelte Fennema <postgres@jeltef.nl>,
 Michael Paquier <michael@paquier.xyz>,
 "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
 Justin Pryzby <pryzby@telsasoft.com>, Noah Misch <noah@leadboat.com>,
 Bruce Momjian <bruce@momjian.us>, Magnus Hagander <magnus@hagander.net>,
 Alvaro Herrera <alvherre@2ndquadrant.com>, Stephen Frost
 <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Peter Eisentraut <peter.eisentraut@enterprisedb.com>
References: <CAGECzQTvfpkyyRoGscSuS7ySCEXOO1DCi3eztHQbGEDrj_nt4g@mail.gmail.com>
 <CAH2-WznOKBQ3HvdwvyXHz18T2u-brkE5umDUic4B-2vtavJKqA@mail.gmail.com>
 <20230811212511.aih23qfthi24zhq4@awork3.anarazel.de>
 <CAH2-Wz=+23=O6iioUR_k9-mgUoX2kJPOWW5JdOXmd5dCtvinVg@mail.gmail.com>
 <338202.1691793002@sss.pgh.pa.us>
 <CAH2-Wz=TNXWQWFgZPehFyPo+9HxxwuHHHYA-ymR+W+kMChM+9Q@mail.gmail.com>
 <342032.1691794926@sss.pgh.pa.us>
 <8c4d8afb-cda1-299c-8011-f60cdaff3999@dunslane.net>
 <20230812211404.sydbwo2juu7vyhtg@awork3.anarazel.de>
 <530189.1691880417@sss.pgh.pa.us>
 <CAH2-Wz=OXmLbQ9ykYYSTmadD=fHtn7-ctCqsco7rc2s3Fvx8QQ@mail.gmail.com>
 <544112.1691886017@sss.pgh.pa.us>
 <CAH2-WzmueQvoZVScpUcAes3Gq_OGCnOH1RXyMicrMdyaAg6OLA@mail.gmail.com>
 <CAH2-WznZ4g8mrHCPVr5MBcSFenFnaKPp2K52JvqLt2fjdcR-bg@mail.gmail.com>
 <CA+TgmoYPycBvESpVkTsEEDrt8PbUnLR1SHSYOKzM_bnkd-UkfQ@mail.gmail.com>
 <CA+TgmoYdrQkr6BBekHJq-1Dga! n=Vuz0kGsfZdJ5_0jx9s+zzqw@mail.gmail.com>
 <2718058.1697552602@sss.pgh.pa.us>
Content-Language: en-US
From: Vik Fearing <vik@postgresfriends.org>
In-Reply-To: <2718058.1697552602@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/69005b14-a48f-4165-becd-22b14b7a5ec3%40postgresfriends.org>
Precedence: bulk

On 10/17/23 16:23, Tom Lane wrote:
> An alternative I was thinking about after reading your earlier email was 
> going back to the status quo ante, but doing the manual tree-wide 
> reindents significantly more often than once a year. Adding one at the 
> conclusion of each commitfest would be a natural thing to do, for 
> instance. It's hard to say what frequency would lead to the least 
> rebasing pain, but we know once-a-year isn't ideal.


This is basically how the SQL Committee functions.  The Change Proposals 
(patches) submitted every meeting (commitfest) are always against the 
documents as they exist after the application of papers (commits) from 
the previous meeting.

One major difference is that Change Proposals are against the text, and 
patches are against the code.  It is not dissimilar to people saying 
what our documentation should say, and then someone implementing that 
change.

So I am in favor of a pgindent run *at least* at the end of each 
commitfest, giving a full month for patch authors to rebase before the 
next fest.
-- 
Vik Fearing