Feedback-ID: ie0a040ee:Fastmail
Content-Type: multipart/mixed; boundary="------------DOC64C0FFl0jmgNEmxlFqJQf"
Message-ID: <690bc5f1-92c7-4bfd-af23-a379a1294bc3@eisentraut.org>
Date: Fri, 15 Dec 2023 12:53:40 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: trying again to get incremental backup
Content-Language: en-US
To: Robert Haas <robertmhaas@gmail.com>,
 Jakub Wartak <jakub.wartak@enterprisedb.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Andres Freund <andres@anarazel.de>, Dilip Kumar <dilipbalaut@gmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
References: <CA+TgmoYiPn7GE_GFvGf+150XOt-Pkdm8h4rzy42jYCRrceUWhg@mail.gmail.com>
 <202311131625.o7hzq3oukuyd@alvherre.pgsql>
 <CA+TgmoafkMay-O7KFyxwYxaT5pZ+ku+qM8hLM88ZzEyq2g-LtQ@mail.gmail.com>
 <CAKZiRmys4AbHJOg2NAqGgjzmHC5CvA3JUHYAaQSG_turxccMFw@mail.gmail.com>
 <CA+TgmoYuC27_ToGtTTNyHgpn_eJmdqrmhJ93bAbinkBtXsWHaA@mail.gmail.com>
 <CA+Tgmob7CFCv99_bCRB=pWYat6r2rhgSqiEWQPJO67ywcb0Hpw@mail.gmail.com>
 <CA+TgmoZpBW2DHeeC--y0H3y1RGsUHb14vinZU4yqBAHtWgv-vg@mail.gmail.com>
 <CA+TgmoaiOhjd0pL630MSpZ_fyjFsARFC8RDBWxWL2FXPv65bJA@mail.gmail.com>
 <CAKZiRmxGN4Eu90xOt8cJwgjV67jNSFsA6Lc_1bgCT5KR-5ywJA@mail.gmail.com>
 <CA+Tgmob4VFT6CuVaxwO0JjLrmCoHF+NNm_f1LsCeSi5i82MeSA@mail.gmail.com>
 <CAKZiRmy73EKi3i5mdtcjn6r6WWQfKuri3HSQ+Pmdu_7g5Ef5kA@mail.gmail.com>
 <CA+TgmoYUhrgcNin=qrY+J+S-f6kctf9DaUKoaD-e3cww_ox9vg@mail.gmail.com>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <CA+TgmoYUhrgcNin=qrY+J+S-f6kctf9DaUKoaD-e3cww_ox9vg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/690bc5f1-92c7-4bfd-af23-a379a1294bc3%40eisentraut.org>
Precedence: bulk

This is a multi-part message in MIME format.
--------------DOC64C0FFl0jmgNEmxlFqJQf
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

I have a couple of quick fixes here.

The first fixes up some things in nls.mk related to a file move.  The 
second is some cleanup because some function you are using has been 
removed in the meantime; you probably found that yourself while rebasing.

The pg_walsummary patch doesn't have a nls.mk, but you also comment that 
it doesn't have tests yet, so I assume it's not considered complete yet 
anyway.

--------------DOC64C0FFl0jmgNEmxlFqJQf
Content-Type: text/plain; charset=UTF-8;
 name="0002-fixup-Move-src-bin-pg_verifybackup-parse_man.patch.nocfbot"
Content-Disposition: attachment;
 filename*0="0002-fixup-Move-src-bin-pg_verifybackup-parse_man.patch.nocf";
 filename*1="bot"
Content-Transfer-Encoding: base64

RnJvbSAwNGFhZTRlZTkxZGRkMWQ0Y2UwNjFjMzZhOTliMGZhMThiZGQ5OGVjIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogVGh1LCAxNCBEZWMgMjAyMyAxMjo1MDozMyArMDEwMApTdWJqZWN0
OiBbUEFUQ0ggMi82XSBmaXh1cCEgTW92ZSBzcmMvYmluL3BnX3ZlcmlmeWJhY2t1cC9wYXJz
ZV9tYW5pZmVzdC5jIGludG8KIHNyYy9jb21tb24uCgotLS0KIHNyYy9iaW4vcGdfdmVyaWZ5
YmFja3VwL25scy5tayB8IDQgKystLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygr
KSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmluL3BnX3ZlcmlmeWJhY2t1
cC9ubHMubWsgYi9zcmMvYmluL3BnX3ZlcmlmeWJhY2t1cC9ubHMubWsKaW5kZXggZWJhNzNh
MmMwNS4uOWU2YTYwNDliYSAxMDA2NDQKLS0tIGEvc3JjL2Jpbi9wZ192ZXJpZnliYWNrdXAv
bmxzLm1rCisrKyBiL3NyYy9iaW4vcGdfdmVyaWZ5YmFja3VwL25scy5tawpAQCAtMSwxMCAr
MSwxMCBAQAogIyBzcmMvYmluL3BnX3ZlcmlmeWJhY2t1cC9ubHMubWsKIENBVEFMT0dfTkFN
RSAgICAgPSBwZ192ZXJpZnliYWNrdXAKIEdFVFRFWFRfRklMRVMgICAgPSAkKEZST05URU5E
X0NPTU1PTl9HRVRURVhUX0ZJTEVTKSBcCi0gICAgICAgICAgICAgICAgICAgcGFyc2VfbWFu
aWZlc3QuYyBcCiAgICAgICAgICAgICAgICAgICAgcGdfdmVyaWZ5YmFja3VwLmMgXAogICAg
ICAgICAgICAgICAgICAgIC4uLy4uL2NvbW1vbi9mZV9tZW11dGlscy5jIFwKLSAgICAgICAg
ICAgICAgICAgICAuLi8uLi9jb21tb24vanNvbmFwaS5jCisgICAgICAgICAgICAgICAgICAg
Li4vLi4vY29tbW9uL2pzb25hcGkuYyBcCisgICAgICAgICAgICAgICAgICAgLi4vLi4vY29t
bW9uL3BhcnNlX21hbmlmZXN0LmMKIEdFVFRFWFRfVFJJR0dFUlMgPSAkKEZST05URU5EX0NP
TU1PTl9HRVRURVhUX1RSSUdHRVJTKSBcCiAgICAgICAgICAgICAgICAgICAganNvbl9tYW5p
ZmVzdF9wYXJzZV9mYWlsdXJlOjIgXAogICAgICAgICAgICAgICAgICAgIGVycm9yX2NiOjIg
XAotLSAKMi40My4wCgo=
--------------DOC64C0FFl0jmgNEmxlFqJQf
Content-Type: text/plain; charset=UTF-8;
 name="0004-fixup-Add-a-new-WAL-summarizer-process.patch.nocfbot"
Content-Disposition: attachment;
 filename*0="0004-fixup-Add-a-new-WAL-summarizer-process.patch.nocfbot"
Content-Transfer-Encoding: base64

RnJvbSAyNTIxMTA0NDY4N2E2MjllNjMyZWYwYTJiZmFkMzBhY2VhMzM3MjY2IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRlciBFaXNlbnRyYXV0IDxwZXRlckBlaXNlbnRy
YXV0Lm9yZz4KRGF0ZTogVGh1LCAxNCBEZWMgMjAyMyAxODozMjoyOSArMDEwMApTdWJqZWN0
OiBbUEFUQ0ggNC82XSBmaXh1cCEgQWRkIGEgbmV3IFdBTCBzdW1tYXJpemVyIHByb2Nlc3Mu
CgotLS0KIHNyYy9iYWNrZW5kL2JhY2t1cC9tZXNvbi5idWlsZCAgICAgICAgIHwgMiArLQog
c3JjL2JhY2tlbmQvcG9zdG1hc3Rlci93YWxzdW1tYXJpemVyLmMgfCA0ICsrLS0KIDIgZmls
ZXMgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp
dCBhL3NyYy9iYWNrZW5kL2JhY2t1cC9tZXNvbi5idWlsZCBiL3NyYy9iYWNrZW5kL2JhY2t1
cC9tZXNvbi5idWlsZAppbmRleCAwZTJkZTkxZTlmLi41ZDRlYmUzZWJlIDEwMDY0NAotLS0g
YS9zcmMvYmFja2VuZC9iYWNrdXAvbWVzb24uYnVpbGQKKysrIGIvc3JjL2JhY2tlbmQvYmFj
a3VwL21lc29uLmJ1aWxkCkBAIC0xMyw1ICsxMyw1IEBAIGJhY2tlbmRfc291cmNlcyArPSBm
aWxlcygKICAgJ2Jhc2ViYWNrdXBfdGhyb3R0bGUuYycsCiAgICdiYXNlYmFja3VwX3pzdGQu
YycsCiAgICd3YWxzdW1tYXJ5LmMnLAotICAnd2Fsc3VtbWFyeWZ1bmNzLmMnCisgICd3YWxz
dW1tYXJ5ZnVuY3MuYycsCiApCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9wb3N0bWFzdGVy
L3dhbHN1bW1hcml6ZXIuYyBiL3NyYy9iYWNrZW5kL3Bvc3RtYXN0ZXIvd2Fsc3VtbWFyaXpl
ci5jCmluZGV4IDdjODQwYzM2YjMuLjlmYTE1NTM0OWUgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNr
ZW5kL3Bvc3RtYXN0ZXIvd2Fsc3VtbWFyaXplci5jCisrKyBiL3NyYy9iYWNrZW5kL3Bvc3Rt
YXN0ZXIvd2Fsc3VtbWFyaXplci5jCkBAIC0yOTAsNyArMjkwLDcgQEAgV2FsU3VtbWFyaXpl
ck1haW4odm9pZCkKIAkJRmx1c2hFcnJvclN0YXRlKCk7CiAKIAkJLyogRmx1c2ggYW55IGxl
YWtlZCBkYXRhIGluIHRoZSB0b3AtbGV2ZWwgY29udGV4dCAqLwotCQlNZW1vcnlDb250ZXh0
UmVzZXRBbmREZWxldGVDaGlsZHJlbihjb250ZXh0KTsKKwkJTWVtb3J5Q29udGV4dFJlc2V0
KGNvbnRleHQpOwogCiAJCS8qIE5vdyB3ZSBjYW4gYWxsb3cgaW50ZXJydXB0cyBhZ2FpbiAq
LwogCQlSRVNVTUVfSU5URVJSVVBUUygpOwpAQCAtMzQyLDcgKzM0Miw3IEBAIFdhbFN1bW1h
cml6ZXJNYWluKHZvaWQpCiAJCVhMb2dSZWNQdHIJZW5kX29mX3N1bW1hcnlfbHNuOwogCiAJ
CS8qIEZsdXNoIGFueSBsZWFrZWQgZGF0YSBpbiB0aGUgdG9wLWxldmVsIGNvbnRleHQgKi8K
LQkJTWVtb3J5Q29udGV4dFJlc2V0QW5kRGVsZXRlQ2hpbGRyZW4oY29udGV4dCk7CisJCU1l
bW9yeUNvbnRleHRSZXNldChjb250ZXh0KTsKIAogCQkvKiBQcm9jZXNzIGFueSBzaWduYWxz
IHJlY2VpdmVkIHJlY2VudGx5LiAqLwogCQlIYW5kbGVXYWxTdW1tYXJpemVySW50ZXJydXB0
cygpOwotLSAKMi40My4wCgo=

--------------DOC64C0FFl0jmgNEmxlFqJQf--