public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: David Rowley <[email protected]>
Cc: Richard Guo <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: A performance issue with Memoize
Date: Thu, 25 Jan 2024 22:51:49 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAApHDvpEOYQeVAt7VxcZc6m7mZqSBxFSPfDNSZzCBcATQrfNzw@mail.gmail.com>
References: <CAMbWs48XHJEK1Q1CzAQ7L9sTANTs9W1cepXu8=Kc0quUL+tg4Q@mail.gmail.com>
<CAApHDvoTyLG35Rm26F7-MFmX3kv-uAs9FD4XF7fqy-B0W6o_UQ@mail.gmail.com>
<[email protected]>
<CAApHDvpEOYQeVAt7VxcZc6m7mZqSBxFSPfDNSZzCBcATQrfNzw@mail.gmail.com>
David Rowley <[email protected]> writes:
> I've adjusted the comments to what you mentioned and also leaned out
> the pretty expensive test case to something that'll run much faster
> and pushed the result.
+1, I was wondering if the test could be cheaper. It wasn't horrid
as Richard had it, but core regression tests add up over time.
>> However ... it seems like we're not out of the woods yet. Why
>> is Richard's proposed test case still showing
>> + -> Memoize (actual rows=5000 loops=N)
>> + Cache Key: t1.two, t1.two
>> Seems like there is missing de-duplication logic, or something.
> This seems separate and isn't quite causing the same problems as what
> Richard wants to fix so I didn't touch this for now.
Fair enough, but I think it might be worth pursuing later.
regards, tom lane
view thread (20+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: A performance issue with Memoize
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox