Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEYRS-0000Wq-Pz for pgsql-hackers@arkaria.postgresql.org; Fri, 13 Aug 2021 14:45:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mEYRR-0007jL-Q4 for pgsql-hackers@arkaria.postgresql.org; Fri, 13 Aug 2021 14:45:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEYRR-0007jD-IA for pgsql-hackers@lists.postgresql.org; Fri, 13 Aug 2021 14:45:49 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mEYRL-0000gM-5E for pgsql-hackers@lists.postgresql.org; Fri, 13 Aug 2021 14:45:49 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 17DEjc7e069594; Fri, 13 Aug 2021 10:45:38 -0400 From: Tom Lane To: Alexander Kukushkin cc: Alvaro Herrera , Pg Hackers Subject: Re: pg_settings.pending_restart not set when line removed In-reply-to: References: <273674.1627398036@sss.pgh.pa.us> <202107272017.rueagj54fhmt@alvherre.pgsql> Comments: In-reply-to Alexander Kukushkin message dated "Fri, 13 Aug 2021 16:30:39 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <69592.1628865938.1@sss.pgh.pa.us> Date: Fri, 13 Aug 2021 10:45:38 -0400 Message-ID: <69593.1628865938@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Alexander Kukushkin writes: > IMO is totally wrong, because the actual value didn't change: it was an > empty string in the config and now it remains an empty string due to the > default value in the guc.c I can't get very excited about that. The existing message about "parameter \"%s\" cannot be changed without restarting the server" was emitted without regard to that fine point, and nobody has complained about it. regards, tom lane